[LU-13053] conf-sanity test 87 call to umount_ldiskfs() fails Created: 06/Dec/19 Updated: 23/Jan/20 Resolved: 23/Jan/20 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.13.0, Lustre 2.14.0, Lustre 2.12.4 |
| Fix Version/s: | Lustre 2.14.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | James Nunez (Inactive) | Assignee: | James Nunez (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | easy, tests | ||
| Severity: | 3 |
| Rank (Obsolete): | 9223372036854775807 |
| Description |
|
conf-sanity test_87 calls umount_ldiskfs() and fails to find the function /usr/lib64/lustre/tests/conf-sanity.sh: line 6334: umount_ldiskfs: command not found The problem is that umount_ldiskfs() does not exist, but unmount_ldiskfs() does exist. conf-sanity test 87 is the only test and only test suite that calls unmount_ldiskfs(). umount_client() is another function that exists and is used throughout conf-sanity. Since the unmount command is umount, let’s be consistent and change unmount_ldiskfs() to umount_ldiskfs(). |
| Comments |
| Comment by Gerrit Updater [ 06/Dec/19 ] |
|
James Nunez (jnunez@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/36949 |
| Comment by James Nunez (Inactive) [ 09/Dec/19 ] |
|
Reviewing all the unmount commands in test-framework, we have the following that use 'umount' in the name: We have the following that use 'unmount' in the name: It looks like we are being a bit inconsistent in naming conventions between clients and servers. In the latest version of the patch, I just changed conf-sanity test 87 to conform to what is in test-framework.sh. |
| Comment by Gerrit Updater [ 23/Jan/20 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/36949/ |
| Comment by Peter Jones [ 23/Jan/20 ] |
|
Landed for 2.14 |