[LU-13060] error: ‘ldiskfs_iget’ undeclared here (not in a function)

• Status: Resolved
• Project: Lustre
• Type: Bug
• Priority: Minor
• Reporter: Jian Yu
• Assignee: Yang Sheng
• Resolution: Duplicate

Environment

Distro/Arch: RHEL8.1/x86_64

• Severity: 3

Description

While building Lustre server on RHEL 8.1 with kernel 4.18.0-147.0.3.el8_1, the build failed as follows:

make[3]: Entering directory '/root/kernel/rpmbuild/BUILD/kernel-4.18.0-147.0.3.el8_1/linux-4.18.0-147.0.3.el8_lustre.x86_64'
  CC [M]  /root/lustre-release/ldiskfs/inode.o
In file included from include/linux/linkage.h:7,
                 from include/linux/fs.h:6,
                 from /root/lustre-release/ldiskfs/inode.c:22:
/root/lustre-release/ldiskfs/inode.c:6294:15: error: ‘ldiskfs_iget’ undeclared here (not in a function); did you mean ‘ldiskfs_ioctl’?
 EXPORT_SYMBOL(ldiskfs_iget);
               ^~~~~~~~~~~~
include/linux/export.h:59:16: note: in definition of macro ‘___EXPORT_SYMBOL’
  extern typeof(sym) sym;      \
                ^~~
/root/lustre-release/ldiskfs/inode.c:6294:1: note: in expansion of macro ‘EXPORT_SYMBOL’
 EXPORT_SYMBOL(ldiskfs_iget);
 ^~~~~~~~~~~~~
make[5]: *** [scripts/Makefile.build:313: /root/lustre-release/ldiskfs/inode.o] Error 1

In kernel 4.18.0-147.0.3.el8_1:

struct inode *__ext4_iget(struct super_block *sb, unsigned long ino,
                          ext4_iget_flags flags, const char *function,
                          unsigned int line);

In previous kernel versions:

struct inode *ext4_iget(struct super_block *sb, unsigned long ino);

Issue Links

• is blocking: LU-12637 Support RHEL 8.1

Comments

[Peter Jones]

Yang Sheng

What do you advise here?

Peter

[Yang Sheng]

Hi, Yujian,

Could you please remove the EXPORT_SYMBOL(ext4_iget) line from ext4_misc.patch? Also please change ext4-large-eas.patch for ext4_iget to adopt 3 args as:

ea_inode = ext4_iget(parent->i_sb, ea_ino, EXT4_IGET_NORMAL);

Thanks,
YangSheng

[Jian Yu]

Sure, Yang Sheng. I'll try that.

[Yang Sheng]

Hi, Yujian,

To fix my previous comment, I think we still need export the __ext4_iget for osd.

Thanks,
Yangsheng

[Jian Yu]

It works. Thank you, Yang Sheng.
RHEL 8.1 server build passed on my local build node. I updated patch https://review.whamcloud.com/36968.