|
We need to add a test that runs "lctl list_param -R '*'" on the client, OSS, MDS, and MGS to verify that parameter names are not being changed or removed by tests. There have been several cases recently with code cleanup between procfs, sysfs, and debugfs where parameter names have been removed, renamed, or moved to some other location without any of the existing regression tests failing.
To ensure the test works properly under a range of filesystem configurations, the canonical parameter list for comparison should be generated with a filesystem name like "fsname" that can be replaced by the test with "$FSNAME" before comparison. Also, all strings that hold an OST or MDT index (e.g. "testfs-OST0003") or client instance (e.g. "llite.myth-ffff880427e80400") should be replaced with a generic string, sorted, and merged, so that the comparison is the same regardless of how many targets are present. Also, the NID shown in MGC files should be sanitized. There will need to be different comparison files for osd-ldiskfs and osd-zfs.
It should be OK for the test if parameters are added (which will happen if running with combined MDS/OSS/client), but not if parameters are removed.
|