[LU-13253] sanity/177 leaves threads blocked in libcfs_debug_dumplog() Created: 15/Feb/20  Updated: 05/Mar/20  Resolved: 05/Mar/20

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.14.0

Type: Bug Priority: Minor
Reporter: Alex Zhuravlev Assignee: Alex Zhuravlev
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Related
is related to LU-8304 libcfs_debug_dumplog calls potentiall... Closed
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

the problem was introduced by:

acb6ee1f1f 2020-02-01 | LU-8304 libcfs: convert debug_ctlwq to a completion

the root cause is that libcfs_debug_dumplog() can be called by few threads simultaneously and each thread re-initialize the global state debug_complete unconditionally.
I reverted the patch locally to pass sanity.sh, but I guess we can wrap libcfs_debug_dumplog() with a mutex to serialize calls.

 Comments   
Comment by Gerrit Updater [ 15/Feb/20 ]

Alex Zhuravlev (bzzz@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/37588
Subject: LU-13253 libcfs: serialize libcfs_debug_dumplog()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 555ded1438c37377925990f4a3d1cf7d5964d42b

Comment by Gerrit Updater [ 05/Mar/20 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/37588/
Subject: LU-13253 libcfs: protect libcfs_debug_dumplog()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: cfba9a1ecc6b20746c289afc8e3c81097e07d8a3

Comment by Peter Jones [ 05/Mar/20 ]

Landed for 2.14

Generated at Sat Feb 10 02:59:42 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.