[LU-13255] Abstract code for wait-with-periodic-warning Created: 17/Feb/20 Updated: 31/Mar/20 Resolved: 31/Mar/20 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | Lustre 2.14.0 |
| Type: | Task | Priority: | Minor |
| Reporter: | Neil Brown | Assignee: | Neil Brown |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Rank (Obsolete): | 9223372036854775807 |
| Description |
|
Lustre has a recurring pattern of waiting for an event and issuing a warning every second while the event hasn't happened. The warning is often set to a higher priority with an exponentially decreasing rate - so after 1,2,4,8,16 seconds etc it is a warning rather than an informational message. It would improve code readability and maintainability to encapsulate this pattern in a macro: wait_var_event_warning() |
| Comments |
| Comment by Gerrit Updater [ 17/Feb/20 ] |
|
Neil Brown (neilb@suse.de) uploaded a new patch: https://review.whamcloud.com/37593 |
| Comment by Gerrit Updater [ 17/Feb/20 ] |
|
Neil Brown (neilb@suse.de) uploaded a new patch: https://review.whamcloud.com/37594 |
| Comment by Gerrit Updater [ 17/Mar/20 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/37593/ |
| Comment by Gerrit Updater [ 31/Mar/20 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/37594/ |
| Comment by Peter Jones [ 31/Mar/20 ] |
|
Landed for 2.14 |