[LU-13276] Potential infinite loop in push target resize code Created: 20/Feb/20 Updated: 05/Mar/20 Resolved: 05/Mar/20 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | Lustre 2.14.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | Chris Horn | Assignee: | Chris Horn |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Severity: | 3 |
| Rank (Obsolete): | 9223372036854775807 |
| Description |
int lnet_push_target_resize(void)
{
...
int nnis = the_lnet.ln_push_target_nnis;
...
again:
...
if (nnis < the_lnet.ln_push_target_nnis)
goto again;
Looks like an infinite loop if we hit the condition for the "goto again" since we don't update the local nnis variable. |
| Comments |
| Comment by Gerrit Updater [ 21/Feb/20 ] |
|
Chris Horn (chris.horn@hpe.com) uploaded a new patch: https://review.whamcloud.com/37676 |
| Comment by Gerrit Updater [ 05/Mar/20 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/37676/ |
| Comment by Peter Jones [ 05/Mar/20 ] |
|
Landed for 2.14 |