[LU-13355] adler32 wrapper in libcfs Created: 11/Mar/20 Updated: 06/May/21 Resolved: 15/May/20 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.14.0 |
| Fix Version/s: | Lustre 2.14.0, Lustre 2.12.5 |
| Type: | Bug | Priority: | Minor |
| Reporter: | Sebastien Buisson | Assignee: | Sebastien Buisson |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | patch | ||
| Issue Links: |
|
||||||||||||||||
| Severity: | 3 | ||||||||||||||||
| Rank (Obsolete): | 9223372036854775807 | ||||||||||||||||
| Description |
|
libcfs has wrappers in order to be able to use adler32 as any other crypto module. But libcfs should not be considered as the owner of this implementation. |
| Comments |
| Comment by Gerrit Updater [ 11/Mar/20 ] |
|
Sebastien Buisson (sbuisson@ddn.com) uploaded a new patch: https://review.whamcloud.com/37878 |
| Comment by Gerrit Updater [ 14/Mar/20 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/37878/ |
| Comment by Gerrit Updater [ 10/Apr/20 ] |
|
|
| Comment by Gerrit Updater [ 10/Apr/20 ] |
|
Sebastien Buisson (sbuisson@ddn.com) uploaded a new patch: https://review.whamcloud.com/38205 |
| Comment by Gerrit Updater [ 19/Apr/20 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/38205/ |
| Comment by Jeremy Filizetti [ 15/May/20 ] |
|
While this patch is much simpler and works around the issue, I would argue that it's incorrect. I can see no use of a hash algorithm in the kernel who implements the functionality but pretends it does not own the algorithm. Even though these are CRC's using the crypto hash APIs, is there a belief that at some point when Lustre is attempted to be upstreamed this would be accepted? I can't imagine this being accepted as is, but I'm by no means an expert.
|