[LU-13359] change lfs quota --pool to print used based only on OSTs from the pool

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.14.0
• Fix Version/s: Lustre 2.14.0
• Type: Task
• Priority: Critical
• Reporter: Sergey Cheremencev
• Assignee: Sergey Cheremencev
• Resolution: Fixed
• Epic/Theme: quota

Description

With https://review.whamcloud.com/35615 "lfs quota --pool" shows correct soft/hard limit and grace time. However used is still the same with used without --pool option, i.e. it prints used for all OSTs in a system. print_obd_quota should be changed to take into account only OSTs from appropriate quota pool. I would like to do this in a separate ticket to make 35615 as small as possible.

Issue Links

• is related to: LU-11023 OST Pool Quotas

Comments

[Patrick Farrell]

Sergey,

A thought: I would do this as a patch on top of 35615, and I think it could use the same LU.  I did this sort of approach for SEL - Generated a patch series, all associated with one ticket.

This is a fix that is not relevant except with 35615, right?  If so, I think it's clearer to just put another patch associated with the original LU.  If I've misunderstood and this fix makes sense without 35615, then never mind.

[Sergey Cheremencev]

Hi Patrick!

Glad to see you hear .

A thought: I would do this as a patch on top of 35615, and I think it could use the same LU.  I did this sort of approach for SEL - Generated a patch series, all associated with one ticket.

That would be nice and yes a patch on top of 35615 is a correct place as there is already an option to show/set quota for the pol.
If so, I will close this ticket - I created it mostly to don't forget about this problem.

[Gerrit Updater]

Sergey Cheremencev ([e-mail]) uploaded a new patch: https://review.whamcloud.com/39298
Subject: LU-13359 quota: make used for pool correct
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 58ebb595ee9f1e28cd4ef8ce2e3d26dcd92c9860

[Andreas Dilger]

While Patrick's comments were OK before the LU-11023 patches were landed, it is better to use separate tickets for issues found after the LU-11023 patches are landed and the ticket closed, as was done with this patch. Otherwise, it is difficult to track patches that have to land to 2.14 in order to make this feature work properly. I've changed this over to "Fix Version: 2.14.0 and "Critical" so that it is tracked properly.

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/39298/
Subject: LU-13359 quota: make used for pool correct
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 6b9f849fd5f49ce68e6102f9c79f52eb11bf949d

[Peter Jones]

Landed for 2.14

[Gerrit Updater]

Neil Brown ([e-mail]) uploaded a new patch: https://review.whamcloud.com/39676
Subject: LU-13359 quota: call rhashtable_lookup near params decl
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 11f22d965757d0535165ef58fc01d5c4d3aeb327

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/39676/
Subject: LU-13359 quota: call rhashtable_lookup near params decl
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 1d116c8ff68fc784141b647b790e4b4861460797