[LU-13380] CLIO: struct cl_io "setattr" attribute not getting copied to sub_io

• Status: Closed
• Project: Lustre
• Type: Bug
• Priority: Major
• Reporter: Arshad Hussain
• Assignee: Wang Shilong (Inactive)
• Resolution: Not a Bug
• Severity: 3

Description

This was see while working on LU-3606. For calls like falloc(), or any call which piggy backs behind SETTER interface and depends upon these attributes. It was noticed that the attributes was not explicitly copied to sub_io under lov_io_sub_init(). This was resulting in attributes under "cl_io.ci_setattr" coming out as 0 as it enters OSC layer. Resulting in osc_io_setattr_start() getting attributes as all 0.

Comments

[Arshad Hussain]

Patch coming up in next 10 mins...

[Gerrit Updater]

Arshad Hussain ([e-mail]) uploaded a new patch: https://review.whamcloud.com/38023
Subject: LU-13380 clio: Explicitly copy "setattr" attribute to sub_io
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 31822eb306217b98480036a271a00698ca870e82

[Wang Shilong (Inactive)]

As commented in the patch, this is not the bug existed for current codes.

If you add any new field into setattr, you need properly inherit it from parents, and the corresponding codes are handled in
lov_io_sub_inherit(), i think this is defect from new support but not existed bug.

[Arshad Hussain]

Wang Shilong, Thanks for your review! I was clearly missing this part.