[LU-13437] rename may miss revoking LOOKUP lock to cause stale dentry on client Created: 08/Apr/20  Updated: 04/Dec/20  Resolved: 28/Jun/20

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.10.0, Lustre 2.12.0, Lustre 2.13.0
Fix Version/s: Lustre 2.14.0, Lustre 2.12.6

Type: Bug Priority: Minor
Reporter: Lai Siyao Assignee: Lai Siyao
Resolution: Fixed Votes: 0
Labels: LTS12

Issue Links:
Related
is related to LU-14172 DIR Stat performance regression in st... Resolved
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

In rename, all objects involved but target may be remote, i.e. source, source parent, target parent may be remote object, herein to know whether source is a remote object on source parent, we need to compare which MDT they are located.

In mdt_getattr_name_lock(), if name is NULL, the LOOKUP lock can't be returned to client, because this object may be a remote object under its parent, and the remote LOOKUP lock is on the MDT where its parent is located.



 Comments   
Comment by Gerrit Updater [ 08/Apr/20 ]

Lai Siyao (lai.siyao@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/38181
Subject: LU-13437 mdt: rename misses remote LOOKUP lock
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 8fb976bde2d872c236ad6333478d5557fdff00bc

Comment by Gerrit Updater [ 10/May/20 ]

Lai Siyao (lai.siyao@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/38560
Subject: LU-13437 lmv: check stripe FID sanity
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 8480b84b1ced58204a089f4d2086970f2e1a29e7

Comment by Gerrit Updater [ 10/May/20 ]

Lai Siyao (lai.siyao@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/38561
Subject: LU-13437 mdt: don't fetch LOOKUP lock for remote object
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: d41dee89741027afbbeb6773083070487bd9e149

Comment by Gerrit Updater [ 02/Jun/20 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/38560/
Subject: LU-13437 lmv: check stripe FID sanity
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 698a496aac51e11791717a9cbd0a86b3525f4557

Comment by Gerrit Updater [ 23/Jun/20 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/38561/
Subject: LU-13437 mdt: don't fetch LOOKUP lock for remote object
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f9a2da63abab5b8b687842166a0b5b5e434ad441

Comment by Gerrit Updater [ 28/Jun/20 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/38181/
Subject: LU-13437 mdt: rename misses remote LOOKUP lock revoke
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 4918fe40db262b19093436caca688c75eb632496

Comment by Peter Jones [ 28/Jun/20 ]

Landed for 2.14

Comment by Gerrit Updater [ 06/Jul/20 ]

Lai Siyao (lai.siyao@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/39289
Subject: LU-13437 uapi: add OBD_CONNECT2_GETATTR_PFID
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: eac0c1645c496faad33053a6de54d8fb079afa3d

Comment by Gerrit Updater [ 06/Jul/20 ]

Lai Siyao (lai.siyao@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/39290
Subject: LU-13437 llite: pack parent FID in getattr
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 87aeb8c84b40cabc17eb1a8163aca3d1f06d661d

Comment by Gerrit Updater [ 20/Jul/20 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/39289/
Subject: LU-13437 uapi: add OBD_CONNECT2_GETATTR_PFID
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f384a8733c41e43ebc2db3c542287a700ace8cbb

Comment by Gerrit Updater [ 07/Aug/20 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/39290/
Subject: LU-13437 llite: pack parent FID in getattr
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 5f2c44bf626b178503c1c4d2d85c40bae087ff4f

Comment by Gerrit Updater [ 07/Aug/20 ]

Minh Diep (mdiep@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/39600
Subject: LU-13437 lmv: check stripe FID sanity
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: f75065d31b370f568ac161d60b59049ce7243c61

Comment by Gerrit Updater [ 07/Aug/20 ]

Minh Diep (mdiep@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/39601
Subject: LU-13437 mdt: rename misses remote LOOKUP lock revoke
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: 3323262a5b5e47dfa3ce37d9f111842c314253b5

Comment by Gerrit Updater [ 31/Aug/20 ]

Lai Siyao (lai.siyao@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/39769
Subject: LU-13437 mdt: don't fetch LOOKUP lock for remote object
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: 0a9690ea662cd95e599b65d2934bb628813308a8

Comment by Gerrit Updater [ 31/Aug/20 ]

Lai Siyao (lai.siyao@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/39770
Subject: LU-13437 uapi: add OBD_CONNECT2_GETATTR_PFID
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: b5e7283aa892f41d668d2e4198692ed2388d0419

Comment by Gerrit Updater [ 31/Aug/20 ]

Lai Siyao (lai.siyao@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/39771
Subject: LU-13437 llite: pack parent FID in getattr
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: f4c8078a970fad489c40d7d21257109847ccfb34

Comment by Gerrit Updater [ 19/Sep/20 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/39600/
Subject: LU-13437 lmv: check stripe FID sanity
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: f1712b36b670dab2da6b7db44b7e06da25df9c34

Comment by Gerrit Updater [ 19/Sep/20 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/39769/
Subject: LU-13437 mdt: don't fetch LOOKUP lock for remote object
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: ae9fc81363bbb4cd5f6e0f6350cc2d6cc33798b3

Comment by Gerrit Updater [ 19/Sep/20 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/39601/
Subject: LU-13437 mdt: rename misses remote LOOKUP lock revoke
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: 23fa920b0ceef8672d0ee6af9c023f96039c61e3

Comment by Gerrit Updater [ 19/Sep/20 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/39770/
Subject: LU-13437 uapi: add OBD_CONNECT2_GETATTR_PFID
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: daa9148294c4e4fb3242c1b4b0a7f28e99ecef51

Comment by Gerrit Updater [ 19/Sep/20 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/39771/
Subject: LU-13437 llite: pack parent FID in getattr
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: 3314727b4d2cb98d4930c0499f75231a95bf4b06

Comment by Gerrit Updater [ 12/Oct/20 ]

Lai Siyao (lai.siyao@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/40218
Subject: LU-13437 mdc: no LOOKUP in IT_GETATTR lock match
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 1f7ffb917a6579256da2be1eb8a2e69258b35f45

Comment by Gerrit Updater [ 12/Oct/20 ]

Lai Siyao (lai.siyao@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/40219
Subject: LU-13437 llite: pass name in getattr by FID
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: c4d8d35312a6918444d0e56b1fcf38274e1a05ef

Comment by Gerrit Updater [ 29/Oct/20 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/40218/
Subject: LU-13437 mdc: remote object support getattr from cache
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 72a1ca996e3a35ce3e4b7e517f77ff7ac83ccdd5

Comment by Gerrit Updater [ 29/Oct/20 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/40219/
Subject: LU-13437 llite: pass name in getattr by FID
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 90ebab5833007defd91e86f5878f356ae5304a1b

Comment by Gerrit Updater [ 29/Oct/20 ]

Minh Diep (mdiep@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/40451
Subject: LU-13437 mdc: remote object support getattr from cache
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: 8138f2f0c3ff43a3a638d83665da3aa83ab0c714

Comment by Gerrit Updater [ 30/Oct/20 ]

Lai Siyao (lai.siyao@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/40482
Subject: LU-13437 llite: pass name in getattr by FID
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: 33d5f5ac03e402bc9c5db322f5eacf69877d7b23

Comment by Gerrit Updater [ 07/Nov/20 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/40451/
Subject: LU-13437 mdc: remote object support getattr from cache
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: 23c05e821da13c6942453be1c9e167c5cafc40e7

Comment by Gerrit Updater [ 07/Nov/20 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/40482/
Subject: LU-13437 llite: pass name in getattr by FID
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: 18578808ff0fc19f16a654f2afb2dc4c70872ef6

Generated at Sat Feb 10 03:01:16 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.