[LU-1347] Lustre coding style change Created: 26/Apr/12  Updated: 18/Oct/13  Resolved: 18/Oct/13

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.4.0, Lustre 2.5.0
Fix Version/s: Lustre 2.4.0, Lustre 2.5.0

Type: Improvement Priority: Minor
Reporter: Peng Tao Assignee: Keith Mannthey (Inactive)
Resolution: Fixed Votes: 0
Labels: emc, patch

Rank (Obsolete): 4521

 Description   

To match kernel coding style, Lustre code need some changes, namingly:
1. Lustre uses expandtab while kernel requires tabs
2. Lustre code have vim syntax rules in most source files, which need to be removed
3. Lustre uses a slightly different comment style, which need to be changed to kernel style

 Comments   
Comment by Liang Zhen (Inactive) [ 07/May/12 ]

patch to remove the vim/emacs modelines is here:
http://review.whamcloud.com/#change,2658

Comment by Xuezhao Liu [ 07/May/12 ]

EXORT_SYMBOLs should be moved to immediately follow the function body, to follow normal Linux coding style. And EXPORT_SYMTAB is obsolete after 2.4 kernel.

Two patches for it:
makes EXPORT_SYMBOL follows function body http://review.whamcloud.com/2670
removes obsolete EXPORT_SYMTAB macros http://review.whamcloud.com/2671

Comment by Xuezhao Liu [ 19/May/12 ]

The big EXPORT_SYMBOL patch is split to multiple smaller patches to reduce confliction possibility.

http://review.whamcloud.com/2836 lnet: makes EXPORT_SYMBOL follows function body
http://review.whamcloud.com/2837 ldlm: makes EXPORT_SYMBOL follows function body
http://review.whamcloud.com/2838 lvfs: makes EXPORT_SYMBOL follows function body
http://review.whamcloud.com/2839 obdclass: makes EXPORT_SYMBOL follows function body
http://review.whamcloud.com/2670 ptlrpc: makes EXPORT_SYMBOL follows function body

Comment by Keith Mannthey (Inactive) [ 04/Jan/13 ]

All patches merged.

Comment by Andreas Dilger [ 21/Jun/13 ]

We need another patch to remove EXPORT_SYMTAB lines that have crept back into the code because of patches that were under development in other branches at the time these patches landed.

Comment by Keith Mannthey (Inactive) [ 21/Jun/13 ]

Part2 EXPORT_SYMTAB patch: http://review.whamcloud.com/6739

Comment by Andreas Dilger [ 18/Oct/13 ]

All patches under this bug have been landed for 2.5.0, please start/clone a new bug for any future patches.

Generated at Sat Feb 10 01:15:50 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.