[LU-13542] osd stats are initialized too late Created: 09/May/20  Updated: 13/Dec/21  Resolved: 13/Dec/21

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.14.0
Fix Version/s: Lustre 2.15.0

Type: Bug Priority: Minor
Reporter: Andrew Perepechko Assignee: Andrew Perepechko
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Related
is related to LU-10607 uninitialized spinlock in osd_zfs Resolved
is related to LU-13309 performance optimizations for brw Resolved
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

Lustre crashes with the following stack trace:

[<ffffffffc113cbac>] lprocfs_oh_tally_pcpu+0x2c/0x40 [obdclass]
[<ffffffffc169719b>] record_start_io.part.14+0x2b/0x40 [osd_zfs]
[<ffffffffc1698322>] osd_read+0xa2/0x180 [osd_zfs]
[<ffffffffc1167dee>] dt_record_read+0x1e/0x70 [obdclass]
[<ffffffffc1190997>] lustre_index_restore+0x527/0x1720 [obdclass]
[<ffffffffc16b2564>] osd_initial_OI_scrub+0xa34/0xd50 [osd_zfs]
[<ffffffffc16b34fd>] osd_scrub_setup+0x9ed/0xb90 [osd_zfs]
[<ffffffffc168a97b>] osd_mount+0xf4b/0x1380 [osd_zfs]

osd_procfs_init()/osd_stats_init() are called after
osd_initial_OI_scrub(), so osd stats are not yet initialized
when osd_read() first tries to update them.

This issue was earlier reported as LU-10607 but was not properly
fixed.



 Comments   
Comment by Andrew Perepechko [ 09/May/20 ]

https://review.whamcloud.com/38554

Comment by Gerrit Updater [ 13/Dec/21 ]

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/38554/
Subject: LU-13542 osd: brw stats are initialized too late
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 546eff6991923f7b3fe959548fd9dbe266c72367

Comment by Peter Jones [ 13/Dec/21 ]

Landed for 2.15

Generated at Sat Feb 10 03:02:09 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.