[LU-13553] o2iblnd: convert LASSERT (tx->tx_sending > 0); to proper error handling

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.14.0, Lustre 2.12.6
• Type: Bug
• Priority: Minor
• Reporter: Amir Shehata (Inactive)
• Assignee: Amir Shehata (Inactive)
• Resolution: Fixed
• Severity: 3

Description

When a tx completes kiblnd_tx_complete() callback is invoked. We ensure:

LASSERT (tx->tx_sending > 0);

However this assert is being triggered in some rare scenarios.

The reasosn tx_sending would be 0 at this point is because:

1. ib_post_send() failed but OFED stack is still sending a tx complete event
2. we're getting two different events for the same tx

Instead of asserting, it'll be better to ignore that tx_complete event and print some more details on the tx in question.

Comments

[Gerrit Updater]

Amir Shehata ([e-mail]) uploaded a new patch: https://review.whamcloud.com/38669
Subject: LU-13553 lnd: gracefully handle unexpected events
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: d5f552cb9662c4c635bb4150f61c633b65fbc582

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/38669/
Subject: LU-13553 lnd: gracefully handle unexpected events
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 60f9f539e686fc19b080a3cda15ade7111bbd4a7

[Peter Jones]

Landed for 2.14

[Gerrit Updater]

Minh Diep ([e-mail]) uploaded a new patch: https://review.whamcloud.com/38752
Subject: LU-13553 lnd: gracefully handle unexpected events
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: 8960fd95ba6cc74b9940105db99ce46389b54d21

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/38752/
Subject: LU-13553 lnd: gracefully handle unexpected events
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: 89e6bf780e33be2020490b28945a53a6d61b8da0