[LU-13609] lctl --device MGS llog_catlist doesn't list all config files. Created: 28/May/20  Updated: 06/Apr/21  Resolved: 04/Jul/20

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.12.4
Fix Version/s: Lustre 2.14.0, Lustre 2.12.6, Lustre 2.12.7, Lustre 2.15.0

Type: Bug Priority: Major
Reporter: Mahmoud Hanafi Assignee: Emoly Liu
Resolution: Fixed Votes: 0
Labels: None

Attachments: File debugfs.ls     File lctl.ls    
Issue Links:
Related
is related to LU-13757 inconsistent indenting in mgs_list_logs Resolved
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

When trying to do a catlist it  is limited to ~304.

nbp8-mds1 ~ # debugfs -c /dev/mapper/nbp8--vg-mgs8 -R 'ls -l /CONFIGS/'   | wc -l
debugfs 1.45.2.wc1 (27-May-2019)
/dev/mapper/nbp8--vg-mgs8: catastrophic mode - not reading inode or group bitmaps
330
nbp8-mds1 ~ # lctl --device MGS llog_catlist |wc -l 
305
nbp2-mds ~ # debugfs -c /dev/mapper/nbp2--vg-mgs2 -R 'ls -l /CONFIGS/'   | wc -l
debugfs 1.45.2.wc1 (27-May-2019)
/dev/mapper/nbp2--vg-mgs2: catastrophic mode - not reading inode or group bitmaps
353
nbp2-mds ~ # lctl --device MGS llog_catlist |wc -l 
304


 Comments   
Comment by Peter Jones [ 28/May/20 ]

Emoly

Could you please investigate?

Thanks

Peter

Comment by Emoly Liu [ 29/May/20 ]

mhanafi,

Could you please save the output list of debugfs and lctl respectively, and upload them here? I want to see which files are not showed by "lctl --device MGS llog_catlist"?

Thanks.

Comment by Mahmoud Hanafi [ 02/Jun/20 ]

See attached listinglctl.ls

Comment by Emoly Liu [ 04/Jun/20 ]

The following files were missed by lctl command:

    940  100644 (1)      0      0   14792 26-Oct-2014 23:35 nbp8-OST000d
    977  100644 (1)      0      0   14792 26-Oct-2014 23:36 nbp8-OST0044
   1027  100644 (1)      0      0   14792 26-Oct-2014 23:36 nbp8-OST0048
    798  100644 (1)      0      0   14792 26-Oct-2014 23:34 nbp8-OST004f
   1031  100644 (1)      0      0   14792 26-Oct-2014 23:36 nbp8-OST0062
    942  100644 (1)      0      0   14792 26-Oct-2014 23:35 nbp8-OST0075
    854  100644 (1)      0      0   14792 26-Oct-2014 23:34 nbp8-OST0087
    981  100644 (1)      0      0   14792 26-Oct-2014 23:36 nbp8-OST00ac
    945  100644 (1)      0      0   14792 26-Oct-2014 23:35 nbp8-OST00c3
    990  100644 (1)      0      0   14792 26-Oct-2014 23:36 nbp8-OST00e1
   1093  100644 (1)      0      0   14792 26-Oct-2014 23:37 nbp8-OST00e9
    888  100644 (1)      0      0   14792 26-Oct-2014 23:35 nbp8-OST00f2
    836  100644 (1)      0      0   14792 26-Oct-2014 23:34 nbp8-OST0108
    845  100644 (1)      0      0   14792 26-Oct-2014 23:34 nbp8-OST0109
    938  100644 (1)      0      0   14792 26-Oct-2014 23:35 nbp8-OST0110
   1017  100644 (1)      0      0   14792 26-Oct-2014 23:36 nbp8-OST0117
   1044  100644 (1)      0      0   14792 26-Oct-2014 23:37 nbp8-OST0133
     14  100644 (1)      0      0       0  5-Jun-2013 21:11 _mgs-sptlrpc
    329  100644 (1)      0      0   61600  2-Jun-2015 08:53 params
     16  100644 (1)      0      0    8192 30-Oct-2018 04:38 nodemap
     17  100644 (1)      0      0       0 20-Aug-2019 09:29 obdfilter-client
     13  100644 (1)      0      0   12288 13-Dec-2018 23:00 mountdata

I will have a check.

Comment by Emoly Liu [ 11/Jun/20 ]

mhanafi,

You are right. This limit (7616 bytes) is from the user data buffer:

int jt_llog_catlist(int argc, char **argv)
{
        struct obd_ioctl_data data;
        char rawbuf[MAX_IOC_BUFLEN], *buf = rawbuf; #MAX_IOC_BUFLEN=8192
        int rc;

        if (argc != 1)
                return CMD_HELP;

        memset(&data, 0, sizeof(data));
        data.ioc_dev = cur_device;
        data.ioc_inllen1 = sizeof(rawbuf) - __ALIGN_KERNEL(sizeof(data), 8);

I will fix it.

Comment by Gerrit Updater [ 12/Jun/20 ]

Emoly Liu (emoly@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/38917
Subject: LU-13609 llog: list all the log files correctly on MGS/MDT
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 77f088f1d0c70ada7ecbee082ec5b2f27269fb8f

Comment by Jay Lan (Inactive) [ 26/Jun/20 ]

We would need a back port to b2_12 when the patch is ready. Thanks.

Comment by Peter Jones [ 27/Jun/20 ]

Jay

Naturally but as per the standard we'll finalize the fix for master first

Peter

Comment by Jay Lan (Inactive) [ 02/Jul/20 ]

Hi Peter,

I understood. My notes was a reminder that the new patch to master branch can not be applied clearnly to b2_12.

Thanks, Jay

Comment by Gerrit Updater [ 04/Jul/20 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/38917/
Subject: LU-13609 llog: list all the log files correctly on MGS/MDT
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 1d97a8b4cd3de9074f323332c7b736367a70d419

Comment by Peter Jones [ 04/Jul/20 ]

Landed for 2.14

Comment by Gerrit Updater [ 10/Jul/20 ]

Emoly Liu (emoly@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/39330
Subject: LU-13609 llog: list all the log files correctly on MGS/MDT
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: 43ec5ab5b889b70e73bcd3faedbfca39fbdcc072

Comment by Gerrit Updater [ 14/Aug/20 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/39330/
Subject: LU-13609 llog: list all the log files correctly on MGS/MDT
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: 678772a15f785bd9365af7dfe83a0c4a34afbdc7

Comment by Gerrit Updater [ 11/Feb/21 ]

Stephane Thiell (sthiell@stanford.edu) uploaded a new patch: https://review.whamcloud.com/41478
Subject: LU-13609 mgs: fix config_log buffer handling
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: d34cfdcfe7361a1ce200eff2b66bdbb7f4e9ccdf

Comment by Gerrit Updater [ 26/Feb/21 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/41478/
Subject: LU-13609 mgs: fix config_log buffer handling
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: e3f17defc141d8847562b610931255d37ed4dd3c

Comment by Gerrit Updater [ 26/Feb/21 ]

Minh Diep (mdiep@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/41777
Subject: LU-13609 mgs: fix config_log buffer handling
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: fb2f027e522bb978801a7862ecc0bb2ac2902a64

Comment by Gerrit Updater [ 06/Apr/21 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/41777/
Subject: LU-13609 mgs: fix config_log buffer handling
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: 7f04890a1b5f806cde7db0666a45b9f73cafa9b8

Generated at Sat Feb 10 03:02:43 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.