[LU-13620] pool_add_targets() defect Created: 02/Jun/20  Updated: 26/Feb/21  Resolved: 26/Feb/21

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.14.0
Fix Version/s: Lustre 2.15.0

Type: Bug Priority: Minor
Reporter: Elena Gryaznova Assignee: Elena Gryaznova
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Related
is related to LU-12506 Client unable to mount filesystem wit... Resolved
Epic/Theme: patch
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   
pool_add_targets()
                local list=$(seq $first $step $last)
 
        do_facet mgs $LCTL pool_add \
                        $FSNAME.$pool $FSNAME-OST[$first-$last/$step]

the function fails if number of osts >= 10 because lct expects numbers in hex



 Comments   
Comment by Gerrit Updater [ 02/Jun/20 ]

Elena Gryaznova (c17455@cray.com) uploaded a new patch: https://review.whamcloud.com/38803
Subject: LU-13620 tests: tests: pool_add_targets() fix
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: ce749697b3e42009400c5c5390d55088df47db25

Comment by Sergey Cheremencev [ 16/Nov/20 ]

Updated a patch solve following issue:

== sanity-quota test 73: bla bla ===================================================================== 21:26:51 (1605551211)
Creating new pool
Pool lustre.qpool created
add targets 1 1
Adding targets to pool
OST lustre-OST0001_UUID added to pool lustre.qpool
add target 0
Adding targets to pool
OST lustre-OST0000_UUID added to pool lustre.qpool
Waiting 90s for 'lustre-OST0000_UUID '
Waiting 80s for 'lustre-OST0000_UUID '
Waiting 70s for 'lustre-OST0000_UUID '
Waiting 60s for 'lustre-OST0000_UUID '
Waiting 50s for 'lustre-OST0000_UUID '
Waiting 40s for 'lustre-OST0000_UUID '
Waiting 30s for 'lustre-OST0000_UUID '
Waiting 20s for 'lustre-OST0000_UUID '
Waiting 10s for 'lustre-OST0000_UUID '
Waiting 0s for 'lustre-OST0000_UUID '
Update not seen after 90s: want 'lustre-OST0000_UUID ' got 'lustre-OST0000_UUID lustre-OST0001_UUID '
 sanity-quota test_73: @@@@@@ FAIL: mds1: Add to pool failed 
  Trace dump:
  = ./../tests/test-framework.sh:6237:error_noexit()
  = ./../tests/test-framework.sh:8999:pool_add_targets()
  = ./sanity-quota.sh:4682:test_73()
  = ./../tests/test-framework.sh:6557:run_one()
  = ./../tests/test-framework.sh:6604:run_one_logged()
  = ./../tests/test-framework.sh:6431:run_test()
  = ./sanity-quota.sh:4686:main() 

pool_add_targets couldn't add just new OST is there is already an OST in a pool.
patch set 2 solves this issue.

Comment by Gerrit Updater [ 26/Feb/21 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/38803/
Subject: LU-13620 tests: pool_add_targets() fix
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 262b6f9c601448f7ed1e4936e390b35406866652

Comment by Peter Jones [ 26/Feb/21 ]

Landed for 2.15

Generated at Sat Feb 10 03:02:48 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.