[LU-13672] tune2fs leaves MMP block in inconsistent state on error Created: 12/Jun/20  Updated: 08/Feb/21  Resolved: 17/Jun/20

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Minor
Reporter: Andreas Dilger Assignee: Andreas Dilger
Resolution: Fixed Votes: 0
Labels: e2fsprogs

Issue Links:
Duplicate
Related
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

Running "tune2fs -O project" on the MGS fails because it may be formatted with 128-byte inode size if smaller than 512MB in size. This prevents the "project" feature from being used because there is no extended inode space to hold the project ID.

As a result, tune2fs exits without resetting the MMP block to an "unused" state, and this prevents the filesystem from being mounted, with an error:

LDISKFS-fs warning (device dm-9): ldiskfs_multi_mount_protect:311: fsck is running on the filesystem 
LDISKFS-fs warning (device dm-9): ldiskfs_multi_mount_protect:311: MMP failure
     info: last update time: 1591374065, last update node: mds-9-0,
     last update device: /dev/mapper/vg_mgs-mgs


 Comments   
Comment by Gerrit Updater [ 12/Jun/20 ]

Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/38926
Subject: LU-13672 tune2fs: reset MMP state on error exit
Project: tools/e2fsprogs
Branch: master-lustre
Current Patch Set: 1
Commit: 4400edf4219b918533bce376c75d33096fd4e591

Comment by Gerrit Updater [ 17/Jun/20 ]

Andreas Dilger (adilger@whamcloud.com) merged in patch https://review.whamcloud.com/38926/
Subject: LU-13672 tune2fs: reset MMP state on error exit
Project: tools/e2fsprogs
Branch: master-lustre
Current Patch Set:
Commit: 6133d63daa9d51922bc23417ca2aa46d544d9e78

Comment by Andreas Dilger [ 17/Jun/20 ]

Patch also submitted upstream to the linux-ext4 mailing list:
https://patchwork.ozlabs.org/project/linux-ext4/patch/20200617114049.93821-1-adilger@dilger.ca/

Comment by Andreas Dilger [ 17/Jun/20 ]

Patch is landed, and will be included in the next e2fsprogs release (1.45.6-wc2 or later).

Generated at Sat Feb 10 03:03:14 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.