[LU-13756] qmt_pool_lock leak in qmt_pool_lookup() Created: 07/Jul/20  Updated: 16/Mar/22  Resolved: 13/Dec/21

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.15.0

Type: Bug Priority: Minor
Reporter: Oleg Drokin Assignee: Sergey Cheremencev
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Related
is related to LU-11023 OST Pool Quotas Resolved
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

It seems that qmt_pool_lookup() jumps to out_err label if qti_pools_add() fails, but the pool lock is not released:

out_err:
        CERROR("%s: cannot add pool %s: err = %d\n",
                qmt->qmt_svname, pos->qpi_name, rc);
        RETURN(ERR_PTR(rc));

seems like a bug?
Introduced by 09f9fb3211c "LU-11023 quota: quota pools for OSTs"

 Comments   
Comment by Gerrit Updater [ 30/Sep/21 ]

"Sergey Cheremencev <sergey.cheremencev@hpe.com>" uploaded a new patch: https://review.whamcloud.com/45106
Subject: LU-13756 quota: up_read leak in qmt_pool_lookup
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 71fe6dd27278df3ca01e0516da3242cf5c81513a

Comment by Gerrit Updater [ 13/Dec/21 ]

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/45106/
Subject: LU-13756 quota: up_read leak in qmt_pool_lookup
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: d16b3141119a3b75276914ad3601e0dd27579b2b

Comment by Peter Jones [ 13/Dec/21 ]

Landed for 2.15

Generated at Sat Feb 10 03:03:56 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.