[LU-13769] osd_dir_it_key and osd_index_it_key feed zap_cursor_retrieve return to ERR_PTR Created: 09/Jul/20 Updated: 09/Jul/20 |
|
| Status: | Open |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.14.0 |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Minor |
| Reporter: | Oleg Drokin | Assignee: | WC Triage |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Severity: | 3 |
| Rank (Obsolete): | 9223372036854775807 |
| Description |
|
it looks like both do
if ((rc = -zap_cursor_retrieve(it->ozi_zc, za)))
RETURN(ERR_PTR(rc));
But in fact it could return a wildly positive value that would break ERR_PTR as advised by smatch? |
| Comments |
| Comment by Oleg Drokin [ 09/Jul/20 ] |
|
similar concern is given about osd_mkreg and osd_it_acct_key lustre/osd-zfs/osd_object.c:1830 osd_mkreg() error: (-2147483647) too low for ERR_PTR lustre/osd-zfs/osd_object.c:1838 osd_mkreg() error: (-2147483647) too low for ERR_PTR lustre/osd-zfs/osd_quota.c:272 osd_it_acct_key() error: (-2147483647) too low for ERR_PTR |