[LU-13841] error messages need additional explanation for lctl pcc commands Created: 31/Jul/20  Updated: 03/Sep/23  Resolved: 05/Aug/20

Status: Closed
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.14.0
Fix Version/s: None

Type: Bug Priority: Trivial
Reporter: Vikentsi Lapa Assignee: WC Triage
Resolution: Fixed Votes: 0
Labels: None
Environment:

Virtual machine

Issue Links:
Related
is related to LU-10499 Readonly Persistent Client Cache support Closed
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

 

From user  perspective:

  • different cases reports same error. 
  • error message itself does not explain what File exists, so it should be documented or changed. Also error message assumed that user knows PCC internals to understand it.

 

From my point of view this can fixed by added some notes or explanation to documentation, or change error message itself, like "cache already enabled for ..."

 

Steps to reproduce:

Directory  for cache is created and exists.

  1. ls /mnt/pcc2

#  lctl pcc add /mnt/lustre /mnt/pcc2 --param "projid={100} rwid=2"

Try to add pcc cache multiple times with same rwid

#  lctl pcc add /mnt/lustre /mnt/pcc2 --param "projid={100} rwid=2"

lctl pcc pcc: error: setting llite.lustre-ffff8b405721f800.pcc='add /mnt/pcc2 projid={100} rwid=2': File exists (17)

 

Try to add pcc cache with same path to /mtn/pcc2 but with  with different rwid

[#  lctl pcc add /mnt/lustre /mnt/pcc2 --param "projid={100} rwid=5"

lctl pcc pcc: error: setting llite.lustre-ffff8b405721f800.pcc='add /mnt/pcc2 projid={100} rwid=5*': File exists (17)*

 

Use incorrect arguments: to get path with numbers

  1. lctl pcc add /mnt/lustre pccro --param projid={100} rwid=2
    add: must specify mount path and PCC path 3:6
    Add a PCC backend to a client.
    usage: lctl pcc add <mntpath> <pccpath> [--param|-p <param>]
    mntpath: Lustre mount point.
    pccpath: Path of the PCC backend.
    param: Setting parameters for PCC backend.

 What is "PCC path 3:6" about? Similar to lctl pcc del

lctl pcc del /mnt/pcc2
del: must speficy mount path and PCC path 1:2
Delete the specified PCC backend on a client.
usage: clt pcc del <mntpath> <pccpath>

 

Typo in error mesage:

del: must speficy mount path and PCC path 1:2  -> specify

 

Incorrect number of arguments in help output:

  1. lctl pcc list
    list: require 2 arguments
    List all PCC backends on a client.
    usage: lctl pcc list <mntpath>**Command output shows 2 arguments in help but only one is required.

 

 Comments   
Comment by Vikentsi Lapa [ 05/Aug/20 ]

This is cosmetic

lctl pcc del /mnt/pcc2
del: must speficy mount path and PCC path

 

 

 

 

 

Comment by Vikentsi Lapa [ 05/Aug/20 ]

Verified with lustre-2.13.55_3_g066eec1-1.el7.x86_64

This was fixed:

 lctl pcc list
list: require 1 arguments
lctl pcc add /mnt/lustre /mnt/pcc2 --param projid={100} rwid=6
add: must specify mount path and PCC path
Add a PCC backend to a client.

 
lctl pcc del /mnt/pcc2 
del: must speficy mount path and PCC path

 

Comment by Vikentsi Lapa [ 05/Aug/20 ]

FYI: qian_wc

Comment by Gerrit Updater [ 27/Aug/23 ]

"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52111
Subject: LU-13841 clio: add cl_dio_pages_complete
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 3c4f0a87e0423a7a734343551228fa80538f7023

Comment by Gerrit Updater [ 27/Aug/23 ]

"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52112
Subject: LU-13841 clio: rename 'cl_page_completion'
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: efb96a2d7fc55217bb90c8f482a9b90a95e1f134

Comment by Gerrit Updater [ 29/Aug/23 ]

"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52159
Subject: LU-13841 osc: convert from list to array
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 646215a9723648cce5257443b2d02222656dd13b

Comment by Gerrit Updater [ 29/Aug/23 ]

"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52161
Subject: LU-13841 osc: reduce queue use in __osc_dio_submit
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: ab05cd1b3a181e600f0d827a032f07a5705377f4

Comment by Gerrit Updater [ 29/Aug/23 ]

"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52163
Subject: LU-13841 osc: test assert
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 0241a815153daf20ffbccc9fb24c539dd51f38b6

Comment by Gerrit Updater [ 29/Aug/23 ]

"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52164
Subject: LU-13841 osc: reduce usage of cdp_cl_pages array
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: a32e30f37994a148596906a614e4623db381bad3

Comment by Gerrit Updater [ 29/Aug/23 ]

"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52165
Subject: LU-13841 clio: add osc_dio_pages_init
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 0ff20153b02afd9665b7a88e95f6f9f8d80de465

Comment by Gerrit Updater [ 29/Aug/23 ]

"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52167
Subject: LU-13841 osc: add osc_dio_completion
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 0ef54bbb5d39332edb9c9e9bb539674a50505f48

Comment by Gerrit Updater [ 30/Aug/23 ]

"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52182
Subject: LU-13841 osc: simplify osc_dio_page_submit
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 06011474f68d4985ca5c97f21897b3491b1af5a2

Comment by Gerrit Updater [ 03/Sep/23 ]

"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52239
Subject: LU-13841 osc: make transfer_page_init take an otp
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 8a47d61b4cd9ef1a6ad9084d77ebb3eedce1f523

Comment by Gerrit Updater [ 03/Sep/23 ]

"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52240
Subject: LU-13841 clio: add cdp_count
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: d964e0636036f3f60ba48066df8cec9ecb010d94

Comment by Gerrit Updater [ 03/Sep/23 ]

"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52241
Subject: LU-13841 osc: make transfer_page_init called for DIO
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 4c8c701c29885f537b950e368c82e799a848c01d

Comment by Gerrit Updater [ 03/Sep/23 ]

"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52242
Subject: LU-13841 osc: flip the switch
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 6bba631b7a2511ee97d909ee759dff47cc749080

Comment by Gerrit Updater [ 03/Sep/23 ]

"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52243
Subject: LU-13841 clio: remove cl_page allocation for DIO
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 3d3a345e8deaa3edca3b549abc416ec0cd6aa9b0

Comment by Gerrit Updater [ 03/Sep/23 ]

"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52244
Subject: LU-13841 osc: change asserts to use OTP type
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: e6f6197e37cff3d05f63650de5b9ba55cadcd434

Comment by Gerrit Updater [ 03/Sep/23 ]

"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52245
Subject: LU-13841 osc: remove cp_type in osc
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 577fde0c95f0276b76fcf44040b4aa72ae170a7c

Comment by Gerrit Updater [ 03/Sep/23 ]

"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52246
Subject: LU-13841 clio: remove cp_type from vvp, mdc, ll
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: a8f9c58520158b222936a4593af8e19da5b0f0ae

Comment by Gerrit Updater [ 03/Sep/23 ]

"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52247
Subject: LU-13841 lov: remove cp_type from lov
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: f179b6db9fcdc9dd018e5fe54515629e51d836b4

Comment by Gerrit Updater [ 03/Sep/23 ]

"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52248
Subject: LU-13841 clio: remove cp_type
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 0ea56126d6edf6fa552eefd18bb4072f74b32328

Comment by Gerrit Updater [ 03/Sep/23 ]

"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52249
Subject: LU-13841 clio: remove type from cl_page_find
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 71ec433e03ca2faad472ba941e7043fdefe2558f

Generated at Sat Feb 10 03:04:40 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.