[LU-13931] lhsm_posix with lt- prefix when build from source tree with --disable-shared Created: 27/Aug/20  Updated: 10/Jan/22  Resolved: 23/Jan/21

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.14.0

Type: Bug Priority: Minor
Reporter: Qian Yingjin Assignee: Qian Yingjin
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Duplicate
duplicates LU-14034 test-framework and sanity-hsm use lib... Resolved
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

It seems that Lustre auto testing system: Lustre Gerrit Janitor using in-tree executed copytools but built with --disable-shared.

The ticket "LU-13688 hsm: handle in-tree executed copytools correctly" change the $HSMTOOL_KILL with "lt-" prefix when found it was testing from in-tree executed copytools. However, when compile with "–disable-shared", the copytool "lhsm_posix" is build without "lt-" prefix.
This results many tests on Lustre Gerrir Janitor failed on HSM related tests such sanity-pcc and sanity-hsm.



 Comments   
Comment by Gerrit Updater [ 27/Aug/20 ]

Oleg Drokin (green@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/39746
Subject: LU-13931 Revert "LU-13688 hsm: handle in-tree executed copytools correctly"
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 3a187c0c5e2204108e2e9e90faa7ec3a468ac183

Comment by James A Simmons [ 27/Aug/20 ]

Instead of reverting I would recommend updating the following:

from_build_tree && LIBTOOL_PREFIX=lt-

to also test if we have dynamic libraries.

[[ from_build_tree && $(which lt-$HSMTOOL) ] && LIBTOOL_PREFIX=lt-

Comment by Qian Yingjin [ 28/Aug/20 ]

We can not use "which lt-$HSMTOOL" as the executable program is $HSMTOOL.

which lt-lhsmtool_posix
which: no lt-lhsmtool_posix in (/root/work/patch/lustre-release/lustre/tests/mpi:/root/work/patch/lustre-release/lustre/tests/racer:/root/work/patch/lustre-release/lustre/../lustre-iokit/sgpdd-survey:/root/work/patch/lustre-release/lustre/utils/gss:/root/work/patch/lustre-release/lustre/utils:/root/work/patch/lustre-release/lustre/tests/.:.:/root/work/patch/lustre-release/lustre/tests/./utils:/usr/share/Modules/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/usr/lib64/mpich/bin/:/root/bin:/sbin:/usr/sbin:)
which lhsmtool_posix
/root/work/patch/lustre-release/lustre/utils/lhsmtool_posix

Instead, we can get the program name via:

export HSMTOOL_KILL=$($HSMTOOL --help | awk '/Usage: / {print $2}')
Comment by Gerrit Updater [ 28/Aug/20 ]

Yingjin Qian (qian@ddn.com) uploaded a new patch: https://review.whamcloud.com/39748
Subject: LU-13931 hsm: get copytool process name correctly
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: f96c1022777eb78babcf16e87cd8ee8ab4374973

Comment by Gerrit Updater [ 30/Aug/20 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/39746/
Subject: LU-13931 Revert "LU-13688 hsm: handle in-tree executed copytools correctly"
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: efb30e3152cf287bb91eac7b9e9605a5db1cccb5

Comment by James A Simmons [ 23/Jan/21 ]

LU-14034 solved this

Generated at Sat Feb 10 03:05:25 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.