[LU-13940] it_lock_bits should be bit-wise tested

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.14.0
• Type: Bug
• Priority: Minor
• Reporter: Shaun Tancheff
• Assignee: Shaun Tancheff
• Resolution: Fixed
• Severity: 3

Description

It was noted during a code review that struct lookup_intent member it_lock_bits is a bitfield but there was a location where it was being tested by an equality test ( != MDS_INODELOCK_OPEN)

If lock_mode is not set then ensure that it_lock_bits has the MDS_INODELOCK_OPEN bit set

Comments

[Gerrit Updater]

Shaun Tancheff ([e-mail]) uploaded a new patch: https://review.whamcloud.com/39797
Subject: LU-13940 llite: it_lock_bits should be bit-wise tested
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 9a39a842ff8ee5b16e5edb390556852cde3288fd

[Andreas Dilger]

Can you please update the ticket with more information about how/when/why this problem is hit, rather than just the patch summary that describes what the patch does. Otherwise, it is very difficult to make any assessment of how often "whatever this problem is" is hit, and what the consequences of hitting it are.

Is it easily hit with a specific workload, does it cause a crash, does it cause data inconsistency or loss, or only an occasional problem that is seen under a specific workload, or just a build problem on a certain kernel or GCC?

[Shaun Tancheff]

This was noted during a code review. I do not have a test that causes this condition to fault.

[Andreas Dilger]

Thanks for the update. This makes it easier to understand the impact of the bug and eg. whether it is important to backport to 2.12 or not.

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/39797/
Subject: LU-13940 llite: it_lock_bits should be bit-wise tested
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 86868afde5a5ebfda9aa8560a464c046d97d14d6

[Peter Jones]

Landed for 2.14