[LU-13977] sanity test_255a uses integer comparison for non-integers Created: 23/Sep/20 Updated: 28/Jan/22 Resolved: 02/Oct/20 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | Lustre 2.14.0 |
| Type: | Improvement | Priority: | Minor |
| Reporter: | Neil Brown | Assignee: | Neil Brown |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||
| Rank (Obsolete): | 9223372036854775807 | ||||||||
| Description |
|
The "-gt" option in the shell "['" (aka "test") command compares integers. ladvise_willread_performance() in sanity.sh uses "scale=2" to ask bc to calculate values to 2 decimal places. These values are then compared with "-gt" which will fail (unless by luck they are integers). This failure is not normally noticed as the error is only reported when no vm is detected. (When I run qemu, no vm is detected, so I notice.) |
| Comments |
| Comment by Gerrit Updater [ 23/Sep/20 ] |
|
Neil Brown (neilb@suse.de) uploaded a new patch: https://review.whamcloud.com/40001 |
| Comment by Gerrit Updater [ 02/Oct/20 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/40001/ |