[LU-14034] test-framework and sanity-hsm use libtool nonsensically Created: 14/Oct/20  Updated: 13/Nov/22  Resolved: 22/Jan/21

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.14.0

Type: Task Priority: Minor
Reporter: John Hammond Assignee: John Hammond
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Duplicate
is duplicated by LU-13931 lhsm_posix with lt- prefix when build... Resolved
Related
is related to LU-15560 Interop: conf-sanity test 125 fails d... Open
is related to LU-12870 sanity-hsm test 9A fails with “uuid D... Resolved
is related to LU-13688 Handle in-tree executed HSM copytools... Resolved
Rank (Obsolete): 9223372036854775807

 Description   

We use libtool several places in lustre/tests/ but only one place uses it correctly:

lustre/tests/conf-sanity.sh:            do_facet ${facet} "libtool execute l_tunedisk ${device}"

All of the following uses are nonsensical:

lustre/tests/sanity-hsm.sh:     do_nodesv $hosts "libtool execute pgrep -x $HSMTOOL"
lustre/tests/sanity-hsm.sh:             "do_nodesv $agents libtool execute pkill -CONT -x '$HSMTOOL' || true" EXIT
lustre/tests/sanity-hsm.sh:     do_nodesv $agents "libtool execute pkill -STOP -x $HSMTOOL" || return 0
lustre/tests/sanity-hsm.sh:     local mntpnt=$(do_rpc_nodes $agent libtool execute ps -C $HSMTOOL -o args= |
lustre/tests/sanity.sh:         # strip out libtool wrappers for in-tree executables
lustre/tests/test-framework.sh: do_nodesv $agents "libtool execute pkill -CONT -x $HSMTOOL" || return 0
lustre/tests/test-framework.sh: do_nodesv $hosts "libtool execute killall -q $HSMTOOL" || true
lustre/tests/test-framework.sh: stack_trap "do_facet $facet libtool execute pkill -x '$HSMTOOL' || true" EXIT

Asking libtool to execute pkill, pgrep, or killall does not fix the problem that this was intended to solve (namely that lhmstool_posix is sometimes a libtool script that execs lt-lhsmtool_posix (which needs to be passed as lt-lhsmtool_pos when used with pkill and pgrep)).

 Comments   
Comment by Gerrit Updater [ 14/Oct/20 ]

John L. Hammond (jhammond@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/40253
Subject: LU-14034 tests: remove libtool usage
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 627b8ff32c6c4c3032d17362545b6613d4178176

Comment by Gerrit Updater [ 22/Jan/21 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/40253/
Subject: LU-14034 hsm: add PID file handling to lhsmtool_posix
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 71a4616b38e81d021a65ee5305b692b271ed0955

Comment by Peter Jones [ 22/Jan/21 ]

Landed for 2.14

Generated at Sat Feb 10 03:06:17 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.