[LU-14264] recovery-small tests 141 and 143 check undefined “PARALLEL” parameter Created: 18/Dec/20 Updated: 11/Jun/22 Resolved: 11/Jun/22 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.14.0, Lustre 2.12.5, Lustre 2.12.6 |
| Fix Version/s: | Lustre 2.16.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | James Nunez (Inactive) | Assignee: | WC Triage |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | tests | ||
| Severity: | 3 |
| Rank (Obsolete): | 9223372036854775807 |
| Description |
|
recovery-small tests 141 and 143 check/compare the value of the PARALLEL parameter, but PARALLEL is not defined in recovery-small.sh nor in any script that recovery-small.sh sources. This does not cause the test to fail. Checking an undefined (non-quoted) variable causes a message/warning in bash and can cause unintended test behavior == recovery-small test 141: do not lose locks on MGS restart ========================================= 11:56:34 (1585310194) /usr/lib64/lustre/tests/recovery-small.sh: line 2985: [: ==: unary operator expected sanity.sh does define PARALLEL with
31 export PARALLEL=${PARALLEL:-"no"}
and all sanity.sh tests can check the value of $PARALLEL without error. To fix this issue, we should probably move the export of the PARALLEL variable found in sanity.sh into the beginning of test-framework.sh which is sourced by all test scripts. recovery-small test 141 was added on 17 MARCH 2020 by https://review.whamcloud.com/#/c/37344/ “ |
| Comments |
| Comment by Gerrit Updater [ 26/Aug/21 ] |
|
"James Nunez <jnunez@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/44763 |
| Comment by Gerrit Updater [ 11/Jun/22 ] |
|
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/44763/ |
| Comment by Peter Jones [ 11/Jun/22 ] |
|
Landed for 2.16 |