[LU-14289] Restrict libcfs to compatibility code only Created: 04/Jan/21  Updated: 05/May/22  Resolved: 05/May/22

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.15.0

Type: Improvement Priority: Minor
Reporter: Neil Brown Assignee: Neil Brown
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Related
is related to LU-9859 libcfs simplification Open
Rank (Obsolete): 9223372036854775807

 Description   

Libcfs currently contains both compatibility code and support code such as abstract-data-types and logging code.  It would be best to keep these separate, particularly in view of the goal of landing lustre in the mainline kernel, where having a "libcfs" would not fit well.

Some of the support code duplicates functionality already provided by Linux, and this is slowly being deprecated and removed in favour of the Linux code.  There is still move to be done.

Other support code is not as generic as it might seem (e.g. heap.c) and would fit well inside the only module that uses it.

The goal of this improvement is to move everything other than compatibility code out of libcfs.  If there is anything remaining that would go in "linux/lib" upsteam, (there might be some, but not much), it should go into a new "lib" directory.

 



 Comments   
Comment by Gerrit Updater [ 05/Jan/21 ]

Neil Brown (neilb@suse.de) uploaded a new patch: https://review.whamcloud.com/41129
Subject: LU-14289 ptlrpc: move heap.c from libcfs to ptlrpc
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: fdab01470d1b38459a53f1cc5c64bc807ba1d085

Comment by Gerrit Updater [ 01/Feb/21 ]

Neil Brown (neilb@suse.de) uploaded a new patch: https://review.whamcloud.com/41375
Subject: LU-14289 ptlrpc: rename cfs_binheap to simply binheap
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 9e393aad2263232dd290bb073e4c483a364ff191

Comment by Gerrit Updater [ 26/Feb/21 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/41129/
Subject: LU-14289 ptlrpc: move heap.c from libcfs to ptlrpc
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f7f0b104bcf3827ffe9025a2347f0147c2103809

Comment by Gerrit Updater [ 10/Mar/21 ]

Neil Brown (neilb@suse.de) uploaded a new patch: https://review.whamcloud.com/41992
Subject: LU-14289 libcfs: discard cfs_array_alloc()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 39747fc6462bb8b43d7f6ba5901b2d95ab425ddb

Comment by Gerrit Updater [ 16/Mar/21 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/41375/
Subject: LU-14289 ptlrpc: rename cfs_binheap to simply binheap
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 8587508f5ddd7b8e764abb4c6fc078ba0f0bf1ad

Comment by Gerrit Updater [ 30/Mar/21 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/41992/
Subject: LU-14289 libcfs: discard cfs_array_alloc()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 8ec9fe0d55b1f5a7854dabe240f43e6cd5cb22ad

Comment by Peter Jones [ 05/May/22 ]

Seems like all patches landed for 2.15

Generated at Sat Feb 10 03:08:27 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.