[LU-14445] hyphen in filename is "legal" but poorly handled

• Status: Open
• Project: Lustre
• Type: Bug
• Priority: Minor
• Reporter: Nathaniel Clark
• Assignee: WC Triage
• Resolution: Unresolved
• Severity: 3

Description

Lustre utils allows for a filesystem to be created with a hyphen ( - ) in the name.

This will lead to odd errors:

• string processing of fsname-target "usually" does the right thing
• Testing for fsname vs target name looks for a hyphen

Workaround: Don't do that

Proposed fix: make hypen an invalid filesystem name character (leaving just alphanumeric and underscore ( _ )

 

Comments

[John Hammond]

Using hyphens in FS names is long supported and commonly used. I do not think we should disallow it. I would suggest that we:

1. Disallow starting with a hyphen. (IIRC we may require somewhere that the FS name starts with a letter. If we don't then that may be a good policy.)
2. Disallow a list of bad substrings "MDT", "OST", "mdtlov", "clilmv", "client", etc.
3. Have an "--i-know-what-i-am-doing" flag in mkfs that allows overriding the check.
4. Audit our source for unsafe/lazy strstr() usage.
5. Consolidate validation and parsing logic into a single place.

[Aurelien Degremont (Inactive)]

I've never seen anybody doing this. I would have say them don't do that, and it is likely not supported. And when I see your comment, i feel like, this is not a good idea to support it