[LU-14543] tgt_grant_discard(): avoid tgd->tgd_tot_granted overflowing Created: 22/Mar/21 Updated: 16/Mar/22 Resolved: 30/Sep/21 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | Lustre 2.12.8, Lustre 2.15.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | Vladimir Saveliev | Assignee: | Vladimir Saveliev |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||||||
| Severity: | 3 | ||||||||||||
| Rank (Obsolete): | 9223372036854775807 | ||||||||||||
| Description |
void tgt_grant_discard(struct obd_export *exp)
...
if (tgd->tgd_tot_granted < ted->ted_grant) {
CERROR("%s: tot_granted %llu < cli %s/%p ted_grant %ld\n",
obd->obd_name, tgd->tgd_tot_granted,
exp->exp_client_uuid.uuid, exp, ted->ted_grant);
}
tgd->tgd_tot_granted -= ted->ted_grant;
...
If tgd->tgd_tot_granted < ted->ted_grant the decrement makes tgd_tot_granted too big. |
| Comments |
| Comment by Gerrit Updater [ 22/Mar/21 ] |
|
Vladimir Saveliev (c17830@cray.com) uploaded a new patch: https://review.whamcloud.com/42129 |
| Comment by Gerrit Updater [ 30/Sep/21 ] |
|
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/42129/ |
| Comment by Peter Jones [ 30/Sep/21 ] |
|
Landed for 2.15 |
| Comment by Gerrit Updater [ 08/Nov/21 ] |
|
"Mike Pershin <mpershin@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/45490 |
| Comment by Gerrit Updater [ 17/Nov/21 ] |
|
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/45490/ |