[LU-14683] replay-single test_40: remove no longer actual test Created: 12/May/21 Updated: 13/Jan/23 Resolved: 13/Jan/23 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.15.0 |
| Fix Version/s: | Lustre 2.16.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | Elena Gryaznova | Assignee: | Elena Gryaznova |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Epic/Theme: | patch |
| Severity: | 3 |
| Rank (Obsolete): | 9223372036854775807 |
| Description |
test_40(){
# always need connection to MDS to verify layout during IO. LU-2628.
lctl get_param mdc.*.connect_flags | grep -q layout_lock &&
skip "layout_lock needs MDS connection for IO" && return 0
should be:
# always need connection to MDS to verify layout during IO. LU-2628.
lctl get_param mdc.*.connect_flags | grep -q layout_lock ||
skip "layout_lock needs MDS connection for IO"
|
| Comments |
| Comment by Andreas Dilger [ 12/May/21 ] |
|
Wow, this code dates back to commit 2.3.62-6-g945a97dbc2, over 8 years ago. I see this subtest is always being skipped in autotest, so the check is clearly incorrect. |
| Comment by Gerrit Updater [ 12/May/21 ] |
|
Elena Gryaznova (c17455@cray.com) uploaded a new patch: https://review.whamcloud.com/43676 |
| Comment by Elena Gryaznova [ 31/May/22 ] |
|
The test is no longer actual for modern Lustre with Layout lock support, as described in the following commit:
commit 945a97dbc2f0323352950d3b54beda9f7ab799a7
Author: Jinshan Xiong <jinshan.xiong@intel.com>
Date: Thu Jan 17 15:11:37 2013 -0800
LU-2628 tests: disable test_40 of replay-single
This test case assumes that IO to OSTs could go on even when the
connect to MDT is lost, this is not true any more because clients
have to verify the layout is correct before operating OST objects.
Signed-off-by: Jinshan Xiong <jinshan.xiong@intel.com>
Change-Id: I08eaad7b97da7ee152c066426f24bc1d15db5738
Reviewed-on: http://review.whamcloud.com/5056
Reviewed-by: Jian Yu <jian.yu@intel.com>
Tested-by: Hudson
Tested-by: Maloo <whamcloud.maloo@gmail.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
|
| Comment by Gerrit Updater [ 13/Jan/23 ] |
|
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/43676/ |
| Comment by Peter Jones [ 13/Jan/23 ] |
|
Landed foe 2.16 |