[LU-14688] Changelog cancel improvement Created: 17/May/21 Updated: 13/May/22 Resolved: 02/Jun/21 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | Lustre 2.12.9, Lustre 2.15.0 |
| Type: | Improvement | Priority: | Minor |
| Reporter: | Alexander Boyko | Assignee: | Alexander Boyko |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | patch | ||
| Issue Links: |
|
||||||||||||||||||||
| Epic/Theme: | changelog | ||||||||||||||||||||
| Rank (Obsolete): | 9223372036854775807 | ||||||||||||||||||||
| Description |
|
llog_changelog_cancel() processing changelog records one by one with llog_changelog_cancel_cb(). The callback decides should this record be deleted base on index at record and cookie from a caller. Since indexes at changelog records are incremented by one, and llog knows max number of records at plain llog, it is easy to calculate current plain llog file would be deleted completely or not. So logic could skip canceling record one by one in this case and delete plain llog file immediately. Plain llog file limited with 64k records, so improvement would help at massive purging, when caller cancels +65k records at once, or cancels all records. |
| Comments |
| Comment by Gerrit Updater [ 17/May/21 ] |
|
Alexander Boyko (alexander.boyko@hpe.com) uploaded a new patch: https://review.whamcloud.com/43719 |
| Comment by Gerrit Updater [ 02/Jun/21 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/43719/ |
| Comment by Peter Jones [ 02/Jun/21 ] |
|
Landed for 2.15 |
| Comment by Gerrit Updater [ 11/Jun/21 ] |
|
Etienne AUJAMES (eaujames@ddn.com) uploaded a new patch: https://review.whamcloud.com/43990 |
| Comment by Etienne Aujames [ 11/Jun/21 ] |
| Comment by Gerrit Updater [ 30/Jan/22 ] |
|
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/43990/ |