[LU-14731] mdd_changelog_llog_init() fails to clear orphans changelog entries when no users are registered Created: 02/Jun/21 Updated: 19/Jul/21 Resolved: 21/Jun/21 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | Lustre 2.15.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | John Hammond | Assignee: | John Hammond |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||
| Severity: | 3 | ||||
| Rank (Obsolete): | 9223372036854775807 | ||||
| Description |
|
In mdd_changelog_llog_init() the logic around getting the minimum user index is broken when there are no users registered. When no users are registered the computed user orphan index is always 0 and the if (unlikely(changelog_orphan.index < user_orphan.index)) branch is never entered. 0 is a poor sentinel for the minimum. It should use the maximum value representable in the type. |
| Comments |
| Comment by Gerrit Updater [ 02/Jun/21 ] |
|
John L. Hammond (jhammond@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/43901 |
| Comment by Gerrit Updater [ 21/Jun/21 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/43901/ |
| Comment by Peter Jones [ 21/Jun/21 ] |
|
Landed for 2.15 |