[LU-14739] capablity check should be aware of root squash

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.15.0
• Type: Bug
• Priority: Minor
• Reporter: Wang Shilong (Inactive)
• Assignee: Wang Shilong (Inactive)
• Resolution: Fixed
• Severity: 3

Description

If root squashed enabled, CAP check should use squash_uid/gid,  quota is one of case hitting problem, as root could exceeding root limits.

Issue Links

• is related to: LU-14901 consume grants if async write fallbac...

Comments

[Gerrit Updater]

.

[Gerrit Updater]

Wang Shilong ([e-mail]) uploaded a new patch: https://review.whamcloud.com/43956
Subject: LU-14739 quota: fix CAP_SYS_RESOURCE check for IO
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 1bceed7ca56c977028b72e7b398129dd386f2586

[Gerrit Updater]

Sebastien Buisson ([e-mail]) uploaded a new patch: https://review.whamcloud.com/43988
Subject: LU-14739 quota: nodemap squashed root cannot bypass quota
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 891a607f74a63ad01a0e6eba28a12c502db3c785

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/43988/
Subject: LU-14739 quota: nodemap squashed root cannot bypass quota
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: a4fbe7341baf12c00c6048bb290f8aa26c05cbac

[Peter Jones]

Landed for 2.15

[Andreas Dilger]

Alex wrote:

i'm getting sanity-quota/10 failures with LU-14739 quota: nodemap squashed root cannot bypass quota, every run (locally)

[Andreas Dilger]

Alex, did you have any more information about the failure you hit with this patch?

[Alex Zhuravlev]

reverting this part fixes sanity-quota/10 on my setup:

@@ -2309,7 +2309,7 @@ int osc_queue_async_io(const struct lu_env *env, struct cl_io *io,
        }
 
        /* check if the file's owner/group is over quota */
-       if (!io->ci_noquota) {
+       if (!(cmd & OBD_BRW_NOQUOTA)) {

[Gerrit Updater]

Wang Shilong ([e-mail]) uploaded a new patch: https://review.whamcloud.com/44347
Subject: LU-14739 quota: don't return quota flags for root
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 7d78fbba52b95fff9efc4cfe7913a213bfb8f691

[Wang Shilong (Inactive)]

bzzz would you give this patch a try? reverting that part will break original problem we want to fix.

[Alex Zhuravlev]

the strange thing is that OSTSIZE=800000 (it's 400000 by default here) fixes the issue as well.

[Alex Zhuravlev]

Alex Zhuravlev would you give this patch a try? reverting that part will break original problem we want to fix.

no, test 10 still fail

[Wang Shilong (Inactive)]

I was able to reproduce problem with OSTSIZE=400000 and i confirmed latest patch help fix issue locally.

[Wang Shilong (Inactive)]

btw, LU-14901 is direct reason why sanity-quota 10 could fail, and patch "LU-14739: quota: nodemap squashed root cannot bypass quota" help expose this bug, i opened new ticket to fix this issue since this is not a regression from this ticket, and there are few regressions problem addressed by https://review.whamcloud.com/#/c/44347/

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/44347/
Subject: LU-14739 quota: fix quota with root squash enabled
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: bbfdc7c1670c92747a8f98d39e1e43dc39e59e30

[Peter Jones]

Landed for 2.15