[LU-1492] cleanup on wirecheck of ptlrpc_body and others Created: 06/Jun/12 Updated: 27/Sep/12 Resolved: 10/Jul/12 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | Lustre 2.3.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | Niu Yawei (Inactive) | Assignee: | Niu Yawei (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Rank (Obsolete): | 4559 |
| Description |
|
Niu, I noticed in the following review page that the ptlrpc_body check is slightly incorrect. http://review.whamcloud.com/#patch,unified,2577,6,lustre/utils/wiretest.c Firstly, there should be a check for both the ptlrpc_body_v1 and prlrpc_body_v3 to ensure that neither of them change. It might be best to have some new type of check that ensures all the fields of ptlrpc_body_v1 have the same size and alignment as those in prlrpc_body_v3. If that is too complex for now, then just restoring the prlrpc_body_v1 check as it was before is fine. Secondly, it seems that the check for the padding offset is using pb_padding[4] instead of just pb_padding, which makes the check for that offset the same as pb_jobid (152) which is a bit confusing. It seems the same is true for the offset of pb_versions. Finally, can you please change the script to add the 2012 copyright in addition to the 2011 year. Cheers, Andreas |
| Comments |
| Comment by Niu Yawei (Inactive) [ 07/Jun/12 ] |
| Comment by Niu Yawei (Inactive) [ 10/Jul/12 ] |
|
patch landed. |