[LU-15163] osd_obj_map_recover() has to restart transaction

• Status: Resolved
• Project: Lustre
• Affects Version/s: Upstream
• Fix Version/s: Lustre 2.16.0
• Type: Bug
• Priority: Minor
• Reporter: Alex Zhuravlev
• Assignee: Alex Zhuravlev
• Resolution: Fixed
• Severity: 3

Description

osd_obj_map_recover() may stop current transaction to call vfs_unlink(), then continue to modify filesystem with no transaction:

                ldiskfs_journal_stop(jh);

                rc = -EEXIST;
                /* If the src object has never been modified, then remove it. */
                if (inode->i_size == 0 && inode->i_mode & S_ISUID &&
                    inode->i_mode & S_ISGID) {
                        rc = ll_vfs_unlink(src_parent, src_child);
                        if (unlikely(rc == -ENOENT))
                                rc = 0;
                }
                if (rc)
                        RETURN(rc);
        }

        bh = osd_ldiskfs_find_entry(src_parent, &src_child->d_name, &de,
                                    NULL, NULL);
        if (unlikely(IS_ERR(bh)))
                GOTO(unlock, rc = PTR_ERR(bh));

        rc = ldiskfs_delete_entry(jh, src_parent, de, bh);

Issue Links

• is related to: LU-15162 improve OI lookup concurrency

Comments

[Gerrit Updater]

"Alex Zhuravlev <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/45368
Subject: LU-15163 osd: osd_obj_map_recover() to restart transaction
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: fe2df9a51dbbf49f1f1534f499a4374c60c812e0

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/45368/
Subject: LU-15163 osd: osd_obj_map_recover() to restart transaction
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 7bf0e557a2b3a463e4d78e81b6ab93987d3dc8af

[Peter Jones]

Landed for 2.16