[LU-15233] Remove extraneous call to cl_page_delete Created: 15/Nov/21 Updated: 13/Sep/23 Resolved: 13/Sep/23 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | Lustre 2.16.0 |
| Type: | Improvement | Priority: | Minor |
| Reporter: | Patrick Farrell | Assignee: | Patrick Farrell |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Rank (Obsolete): | 9223372036854775807 |
| Description |
|
This seems to have been a mistake. cl_page_discard causes page invalidation, which calls ll_invalidatepage, which calls cl_page_delete if the page can be found. Since the page is locked here and ll_invalidatepage checks for the page (checking that the result of cl_vmpage_page != NULL), this has probably never caused an issue. But it's extraneous and kind of weird, and misled me a bit when working on another bug. |
| Comments |
| Comment by Gerrit Updater [ 15/Nov/21 ] |
|
"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/45583 |
| Comment by Gerrit Updater [ 13/Sep/23 ] |
|
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/45583/ |
| Comment by Peter Jones [ 13/Sep/23 ] |
|
Landed for 2.16 |