[LU-15392] mdt_mfd_close() error proapgation Created: 22/Dec/21 Updated: 27/Dec/21 |
|
| Status: | Open |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.12.9 |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Minor |
| Reporter: | John Hammond | Assignee: | Zhenyu Xu |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||
| Severity: | 3 | ||||||||
| Rank (Obsolete): | 9223372036854775807 | ||||||||
| Description |
|
Even after https://review.whamcloud.com/#/c/45636/ lands there will still be error propagation issues in mdt_mdt_close(). This function will "continue to close even if error occurred". If an error occurs in one of the MDS_HSM_RELEASE, MDS_CLOSE_LAYOUT_*, or MDS_CLOSE_RESYNC_DONE cases then we need to ensure that the error is properly returned and is seen by the sender of the close RPC. Please go through this function line-by-line to ensure that we are propagating and not clobbering errors. We should also make sure that we are masking errors properly in some cases. |
| Comments |
| Comment by Zhenyu Xu [ 27/Dec/21 ] |
|
Will update the patch, and will make sure to return the close intent error code if possible. Then close error code is secondarily important one to return if intent operation has been finished, then miscellaneous update error code is thirdly to be returned. |