[LU-154] Prototype of d_compare has changed in 2.6.38

• Status: Closed
• Project: Lustre
• Type: Improvement
• Priority: Minor
• Reporter: Johann Lombardi (Inactive)
• Assignee: Johann Lombardi (Inactive)
• Resolution: Fixed

Description

The prototype of ->d_compare has changed in 2.6.38. See the kernel commit for more information.

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=621e155a3591962420eacdd39f6f0aa29ceb221e

Comments

[Build Master (Inactive)]

Integrated in reviews-centos5 #549
LU-154 Prototype of d_compare has changed in 2.6.38

Johann Lombardi : 2f305c87c2454498ec9583d7d78fc8e7000c7176
Files :

• lustre/llite/dcache.c
• lustre/autoconf/lustre-core.m4

[Build Master (Inactive)]

Integrated in reviews-centos5 #551
LU-154 cleanup some dead code

Johann Lombardi : bd84f8e704cda8c7f9e9792d35fd71b84326b55d
Files :

• lustre/llite/dcache.c
• lustre/llite/symlink.c
• lustre/llite/llite_internal.h
• lustre/include/linux/lustre_acl.h
• lustre/ldlm/ldlm_lock.c
• lustre/llite/namei.c
• lustre/include/linux/obd.h
• lustre/lmv/lmv_intent.c
• lustre/llite/file.c
• lustre/include/lustre_mdc.h
• lustre/obdclass/linux/linux-module.c
• lustre/include/linux/lustre_mds.h
• lustre/include/linux/lustre_intent.h

[Wally Wang (Inactive)]

For the d_compare patch, there are more places need to be patched:

dcache.c:

For the couple of d_mountpoint(dchild) calls in ll_dcompare(), the compiler will complain about dchild since it has the extra const qualifier.

llite_internal.h:

The ll_dcompare() needs to be ifdef'd for the interface change.

[Johann Lombardi (Inactive)]

I think Lai took care of this.