[LU-15421] Missing error() calls in test scripts Created: 07/Jan/22 Updated: 11/Jan/22 Resolved: 11/Jan/22 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.15.0 |
| Fix Version/s: | Lustre 2.15.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | Oleg Drokin | Assignee: | Oleg Drokin |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Severity: | 3 |
| Rank (Obsolete): | 9223372036854775807 |
| Description |
|
Looks like we have several instances of errors that forget to call the error primitive
$ git grep '|| "' | grep -i fail lustre/tests/sanity-flr.sh: $LFS mirror read -N2 -o $TMP/$tfile $DIR/$tfile || "read mirror failed" lustre/tests/sanity-flr.sh: $LFS mirror write -N2 -i /etc/passwd $DIR/$tfile || "write failed" lustre/tests/sanity-pfl.sh: rm -f $comp_file || "Delete $comp_file failed" lustre/tests/sanity-pfl.sh: rm $comp_file || "Delete composite failed" lustre/tests/sanity.sh: createmany -d $DIR/$tdir/d 6 || "(2) fail to mkdir" and lustre/tests/sanity-lfsck.sh: cat $DIR/$tdir/$tfile && "$DIR/$tdir/$tfile: read should fail" lustre/tests/sanity.sh: touch $DIR/$tdir/$tdir/$tfile && "$DIR/$tdir: file create should fail" lustre/tests/sanity.sh: touch $DIR/$tdir/$tdir/$tfile && "$DIR/$tdir: file create should fail" |
| Comments |
| Comment by Gerrit Updater [ 07/Jan/22 ] |
|
"Oleg Drokin <green@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/45995 |
| Comment by Gerrit Updater [ 10/Jan/22 ] |
|
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/45995/ |