[LU-15492] Fix fallthrough decorator to use __attribute__((fallthrough)) for gcc 7

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.16.0, Lustre 2.15.1
• Type: Bug
• Priority: Minor
• Reporter: Shaun Tancheff
• Assignee: Shaun Tancheff
• Resolution: Fixed
• Severity: 3

Description

Using the new fallthrough macro, building on openSUSE 15 with gcc-7.5

error: this statement may fall through [-Werror=implicit-fallthrough=]

Where the fallthrough attribute is available prefer it over a no-op suppression of
the implicit fallthrough warning.

Ex:

# if defined(__GNUC__) && __GNUC__ >= 7
#  define fallthrough  __attribute__((fallthrough)) /* fallthrough */
# else
#  define fallthrough do {} while (0)  /* fallthrough */
# endif

Comments

[Gerrit Updater]

"Shaun Tancheff <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/46357
Subject: LU-15492 build: fallthrough macro for pre/post gcc-7
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 51f7cf74e67ceb23d7da44f16cdcb4131fe5bfaf

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/46357/
Subject: LU-15492 build: fallthrough macro for pre/post gcc-7
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 7b54fc7b1615f23a1ad9da84ba8e289de1f22d70

[Peter Jones]

Landed for 2.16

[Gerrit Updater]

"Jian Yu <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/47708
Subject: LU-15492 build: fallthrough macro for pre/post gcc-7
Project: fs/lustre-release
Branch: b2_15
Current Patch Set: 1
Commit: fe41df79987bf7bdd8c76299a3c223ce560c0529

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/47708/
Subject: LU-15492 build: fallthrough macro for pre/post gcc-7
Project: fs/lustre-release
Branch: b2_15
Current Patch Set:
Commit: 2fd2a6fb7f6935624d327e8bfe25dd3955066429