[LU-15508] Lnet IPv6 work exposed memory leak in GSS layer Created: 01/Feb/22  Updated: 07/Jan/24  Resolved: 11/Jun/22

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.15.0
Fix Version/s: Lustre 2.16.0, Lustre 2.15.2

Type: Bug Priority: Minor
Reporter: James A Simmons Assignee: Sebastien Buisson
Resolution: Fixed Votes: 0
Labels: IPv6

Issue Links:
Related
is related to LU-10391 LNET: Support IPv6 Reopened
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

While testing a LU-10391 patch that touched LNetPrimaryNID() in the GSS code that patch was done incorrectly which lead to a failure path being exercised in the GSS layer that normally is not. The test failures showed an unknown memory leak which can be seen here.

https://testing.whamcloud.com/gerrit-janitor/21309/testresults/runtests-ssk-ldiskfs-SSK-centos7_x86_64-centos7_x86_64/

 



 Comments   
Comment by Gerrit Updater [ 03/Feb/22 ]

"James Simmons <jsimmons@infradead.org>" uploaded a new patch: https://review.whamcloud.com/46449
Subject: LU-15508 gss: debug for memory leak
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 0e27d72762e28d2fe8e4b6ef2c8638bb451cc530

Comment by Gerrit Updater [ 04/Feb/22 ]

"Sebastien Buisson <sbuisson@ddn.com>" uploaded a new patch: https://review.whamcloud.com/46461
Subject: LU-15508 gss: protect from arbitrary write to init channel
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: b71cfdf8661e35ba8570ceb600af121ffabd48e5

Comment by Sebastien Buisson [ 04/Feb/22 ]

Memory leak was due to garbage written to /proc/net/rpc/auth.sptlrpc.init/channel by lsvcgssd daemon in case it was getting badly formatted auth data from kernel space (as it happened with incorrect patchset 8 or 9 of https://review.whamcloud.com/43616, because only kernel space format was changed).

Comment by Gerrit Updater [ 11/Jun/22 ]

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/46461/
Subject: LU-15508 gss: protect from arbitrary write to init channel
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f06807d409c82dd85c208c79c8072402e77f9bac

Comment by Peter Jones [ 11/Jun/22 ]

Landed for 2.16

Comment by Gerrit Updater [ 17/Jun/22 ]

"Sebastien Buisson <sbuisson@ddn.com>" uploaded a new patch: https://review.whamcloud.com/47668
Subject: LU-15508 gss: protect from arbitrary write to init channel
Project: fs/lustre-release
Branch: b2_15
Current Patch Set: 1
Commit: 444ed0ecb0747edd16e64ad7373e15b0da69dc1d

Generated at Sat Feb 10 03:18:55 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.