[LU-15521] RPM 4.16 support Created: 06/Feb/22 Updated: 09/Jan/24 Resolved: 09/Jan/24 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | Lustre 2.16.0 |
| Type: | Improvement | Priority: | Minor |
| Reporter: | Jian Yu | Assignee: | Jian Yu |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||||||||||
| Rank (Obsolete): | 9223372036854775807 | ||||||||||||||||
| Description |
|
RPM 4.16 removed support for bare words in expressions (eg a == b needs to be "a" == "b" now). More changes are in: The following errors in lustre.spec and lustre-dkms.spec need to be resolved: # rpm --version
RPM version 4.16.1.3
# find . -name "*.spec" | xargs rpmlint
./lustre.spec:442: W: macro-in-comment %optflags
./lustre.spec:469: W: macro-in-comment %{name}
./lustre.spec:723: E: hardcoded-library-path in %{_prefix}/lib/ocf/resource.d/lustre/
./lustre.spec:110: W: mixed-use-of-spaces-and-tabs (spaces: line 110, tab: line 59)
./lustre.spec: E: specfile-error error: bare words are no longer supported, please use "...": redhat=="redhat" || redhat=="fedora"
./lustre.spec: E: specfile-error error: ^
./lustre.spec: E: specfile-error error: ./lustre.spec:133: bad %if condition: redhat=="redhat" || redhat=="fedora"
./lustre.spec: E: specfile-error error: query of specfile ./lustre.spec failed, can't parse
./lustre-dkms.spec:79: W: unversioned-explicit-provides lustre-dkms
./lustre-dkms.spec:80: W: unversioned-explicit-obsoletes lustre-dkms
./lustre-dkms.spec:107: W: unversioned-explicit-provides lustre-osd
./lustre-dkms.spec:109: W: unversioned-explicit-provides lustre-client
./lustre-dkms.spec:144: E: hardcoded-library-path in /usr/lib/dkms/common.postinst
./lustre-dkms.spec:40: W: mixed-use-of-spaces-and-tabs (spaces: line 40, tab: line 12)
./lustre-dkms.spec: E: specfile-error error: bare words are no longer supported, please use "...": redhat=="redhat" || redhat=="fedora"
./lustre-dkms.spec: E: specfile-error error: ^
./lustre-dkms.spec: E: specfile-error error: ./lustre-dkms.spec:31: bad %if condition: redhat=="redhat" || redhat=="fedora"
./lustre-dkms.spec: E: specfile-error error: query of specfile ./lustre-dkms.spec failed, can't parse
0 packages and 2 specfiles checked; 10 errors, 8 warnings.
|
| Comments |
| Comment by Gerrit Updater [ 07/Feb/22 ] |
|
"Jian Yu <yujian@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/46471 |
| Comment by Jian Yu [ 07/Feb/22 ] |
|
More issues need to be resolved: warning: /tmp/rpmbuild-lustre-root-IAPduFT5/SPECS/lustre.spec: line 272: Macro %kmp_release defined but not used within scope
warning: /tmp/rpmbuild-lustre-root-IAPduFT5/SPECS/lustre.spec: line 272: Macro %kmp_version defined but not used within scope
warning: /tmp/rpmbuild-lustre-root-IAPduFT5/SPECS/lustre.spec: line 272: Macro %latest_kernel defined but not used within scope
warning: /tmp/rpmbuild-lustre-root-IAPduFT5/SPECS/lustre.spec: line 275: Macro %kmp_release defined but not used within scope
warning: /tmp/rpmbuild-lustre-root-IAPduFT5/SPECS/lustre.spec: line 275: Macro %kmp_version defined but not used within scope
warning: /tmp/rpmbuild-lustre-root-IAPduFT5/SPECS/lustre.spec: line 275: Macro %latest_kernel defined but not used within scope
warning: /tmp/rpmbuild-lustre-root-IAPduFT5/SPECS/lustre.spec: line 377: Macro %kmp_release defined but not used within scope
warning: /tmp/rpmbuild-lustre-root-IAPduFT5/SPECS/lustre.spec: line 377: Macro %kmp_version defined but not used within scope
warning: /tmp/rpmbuild-lustre-root-IAPduFT5/SPECS/lustre.spec: line 377: Macro %latest_kernel defined but not used within scope
sh: -c: line 13: syntax error near unexpected token `('
sh: -c: line 13: ` /usr/bin/sed -r --in-place=.backup 's/^char \(\*f\) \(\) = /__attribute__ ((used)) char (*f) () = /g' $file; '
The issues came from the following codes: lustre.spec.in %if 0%{?rhel} == 7 # until we have achieved full kABI compatibility we need to # restrict the kernel range that can be used to the kernel # version from the RHEL minor release # this is supposed to be done for kmods automatically but # RHBZ#1467319 seems to be getting in the way # this is true for el7.0 through el7.4 %define preamble %{expand:%( TMPFILE=`mktemp` cat %{SOURCE1} > $TMPFILE kver=%{kernel_version} linuxversion=${kver%%%%-*} linuxrelease=${kver##*-} kabiminor=${linuxrelease%%%%.*} echo "Requires: kernel < $linuxversion-$((kabiminor+1)), kernel >= $linuxversion-$((kabiminor))" >> $TMPFILE echo $TMPFILE )} %else %define preamble %{SOURCE1} %endif %kernel_module_package -n %{name} -p %preamble -f %SOURCE2 %{_flavor} |
| Comment by Gerrit Updater [ 11/Jun/22 ] |
|
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/46471/ |
| Comment by Peter Jones [ 11/Jun/22 ] |
|
Landed for 2.16 |
| Comment by Jian Yu [ 12/Jun/22 ] |
|
More issues need to be resolved. |
| Comment by Gerrit Updater [ 23/Jun/22 ] |
|
"Jian Yu <yujian@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/47710 |
| Comment by Gerrit Updater [ 29/Jun/22 ] |
|
"Jian Yu <yujian@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/47833 |
| Comment by Gerrit Updater [ 29/Jun/22 ] |
|
"Jian Yu <yujian@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/47835 |
| Comment by Gerrit Updater [ 05/Jul/22 ] |
|
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/47710/ |
| Comment by Gerrit Updater [ 10/Jul/22 ] |
|
"Shaun Tancheff <shaun.tancheff@hpe.com>" uploaded a new patch: https://review.whamcloud.com/47929 |
| Comment by Gerrit Updater [ 15/Jul/22 ] |
|
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/47833/ |
| Comment by Gerrit Updater [ 15/Jul/22 ] |
|
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/47835/ |