[LU-15522] liblnetconfig should not export readline Created: 06/Feb/22 Updated: 13/Jun/22 Resolved: 11/Jun/22 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | Lustre 2.16.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | John Hammond | Assignee: | John Hammond |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Severity: | 3 |
| Rank (Obsolete): | 9223372036854775807 |
| Description |
|
If HAVE_LIBREADLINE is not defined then liblnetconfig.so will export readline(). This is a bug since it breaks readline if liblnetconfig is linked before libreadline. |
| Comments |
| Comment by Gerrit Updater [ 06/Feb/22 ] |
|
"John L. Hammond <jhammond@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/46465 |
| Comment by Oleg Drokin [ 11/Jun/22 ] |
|
just wonder how could libreadline be linked if HAVE_LIBREADLINE is not set? |
| Comment by Gerrit Updater [ 11/Jun/22 ] |
|
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/46465/ |
| Comment by Peter Jones [ 11/Jun/22 ] |
|
Landed for 2.16 |
| Comment by John Hammond [ 13/Jun/22 ] |
|
> just wonder how could libreadline be linked if HAVE_LIBREADLINE is not set? By telling the linker to do so. HAVE_READLINE depends on the readline headers being installed. |