[LU-15598] page leak on cfs_crypto_hash_init() error path in tgt_checksum_niobuf_t10pi Created: 27/Feb/22  Updated: 11/Jun/22  Resolved: 11/Jun/22

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.16.0

Type: Bug Priority: Minor
Reporter: Oleg Drokin Assignee: Andreas Dilger
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Related
is related to LU-15615 memory leak on use_t10_grd path in tg... Resolved
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

seems to be leaking allocated page if there was crypto init error:

 

        __page = alloc_page(GFP_KERNEL);
        if (__page == NULL)
                return -ENOMEM;
        req = cfs_crypto_hash_init(cfs_alg, NULL, 0);
        if (IS_ERR(req)) {
                CERROR("%s: unable to initialize checksum hash %s\n",
                       tgt_name(tgt), cfs_crypto_hash_name(cfs_alg));
                return PTR_ERR(req);
        }
 


 Comments   
Comment by Gerrit Updater [ 01/Mar/22 ]

"Andreas Dilger <adilger@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/46659
Subject: LU-15598 tgt: free allocated page on error
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: f3cab6e251637f083418effb59e2944ed303b7f7

Comment by Gerrit Updater [ 11/Jun/22 ]

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/46659/
Subject: LU-15598 tgt: free allocated page on error
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 812df05892d39ba2487d5de15bf66878be4590ae

Comment by Peter Jones [ 11/Jun/22 ]

Landed for 2.16

Generated at Sat Feb 10 03:19:41 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.