[LU-15600] mdc_changelog_cdev_init frees memory without removing it from list

• Status: Open
• Project: Lustre
• Affects Version/s: Lustre 2.15.0
• Type: Bug
• Priority: Minor
• Reporter: Oleg Drokin
• Assignee: Mikhail Pershin
• Resolution: Unresolved
• Severity: 3

Description

        list_add_tail(&obd->u.cli.cl_chg_dev_linkage, &entry->ced_obds);
        list_add_tail(&entry->ced_link, &chlg_registered_devices);
        rc = chlg_minor_alloc(&minor);
        if (rc)
                GOTO(out_unlock, rc);
...
out_minor:
        chlg_minor_free(minor);
        list_del_init(&obd->u.cli.cl_chg_dev_linkage);
        list_del(&entry->ced_link);
out_unlock:
        mutex_unlock(&chlg_registered_dev_lock);
        if (entry)
                OBD_FREE_PTR(entry);
        RETURN(rc);
 

Comments

[John Hammond]

tappro will you take a look at this please?

[Andreas Dilger]

looks like the out_unlock: label just needs to be moved up before the list_del_init() call.