[LU-15612] Replace unicode double quotes with ASCII(text) Created: 03/Mar/22  Updated: 30/Mar/22  Resolved: 30/Mar/22

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.15.0

Type: Bug Priority: Minor
Reporter: Arshad Hussain Assignee: Arshad Hussain
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Related
is related to LU-15617 Add shellcheck to prepare-commit-msg Resolved
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

Under test conf-sanity.sh/test_4 , error message was quoted with unicode double quotes. This is replaced with ascii(text) double quotes. This is not incorrect, but may not be compatible with certain(very old) displays.



 Comments   
Comment by Gerrit Updater [ 03/Mar/22 ]

"Arshad Hussain <arshad.hussain@aeoncomputing.com>" uploaded a new patch: https://review.whamcloud.com/46687
Subject: LU-15612 tests: Replace unicode double quotes
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 29e84f8d00a027d8a086dbd11647ed3b0c05c216

Comment by Andreas Dilger [ 03/Mar/22 ]

You've found a few different issues with shellcheck. It might be interesting to have it run on newly-added subtests automatically as part of "checkpatch.pl" or otherwise hooked into contrib/git-hooks/commit-msg.

Comment by Arshad Hussain [ 04/Mar/22 ]

Will add it under git-hooks. Thanks.

Comment by Gerrit Updater [ 30/Mar/22 ]

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/46687/
Subject: LU-15612 tests: Replace unicode double quotes
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 4af4f48e9e5e01c39ab0485a3512a554991e1c1b

Comment by Peter Jones [ 30/Mar/22 ]

Landed for 2.15

Generated at Sat Feb 10 03:19:48 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.