[LU-15614] Variable incorrectly used in sanity-flr/203 Created: 03/Mar/22  Updated: 30/Mar/22  Resolved: 30/Mar/22

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.15.0

Type: Bug Priority: Minor
Reporter: Arshad Hussain Assignee: Arshad Hussain
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Related
is related to LU-15617 Add shellcheck to prepare-commit-msg Resolved
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

Under sanity-flr.sh/203 variable 'old_id' and
 'new_id' is defined incorrectly as 'oldid' and
 'newid'. This leads to a comparison between the
 two as always true and leading to false positive.
 This was exposed using shellcheck.
    
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    In lustre/tests/sanity-flr.sh line 3258:
    [[ x$oldid = x$newid ]] ||
    ^-- SC2154: oldid is referenced but not assigned (did you mean 'old_id'?).
    ^-- SC2154: newid is referenced but not assigned (did you mean 'new_id'?).
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~



 Comments   
Comment by Gerrit Updater [ 03/Mar/22 ]

"Arshad Hussain <arshad.hussain@aeoncomputing.com>" uploaded a new patch: https://review.whamcloud.com/46690
Subject: LU-15614 tests: Variable incorrectly used in sanity-flr/203
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: b81fac3667fd4203628c5a23a5b8b4f31ef7a67b

Comment by Gerrit Updater [ 30/Mar/22 ]

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/46690/
Subject: LU-15614 tests: Variable incorrectly used in sanity-flr/203
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 94dee86fbcf72ded71c633f7de1bdf2713d6d769

Comment by Peter Jones [ 30/Mar/22 ]

Landed for 2.15

Generated at Sat Feb 10 03:19:49 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.