[LU-15617] Add shellcheck to prepare-commit-msg Created: 04/Mar/22 Updated: 11/Jun/22 Resolved: 11/Jun/22 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | Lustre 2.16.0 |
| Type: | Improvement | Priority: | Minor |
| Reporter: | Arshad Hussain | Assignee: | Arshad Hussain |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||
| Rank (Obsolete): | 9223372036854775807 | ||||||||||||||||||||||||||||||||||||
| Description |
|
Add shellcheck to prepare-commit-msg. |
| Comments |
| Comment by Gerrit Updater [ 04/Mar/22 ] |
|
"Arshad Hussain <arshad.hussain@aeoncomputing.com>" uploaded a new patch: https://review.whamcloud.com/46705 |
| Comment by Andreas Dilger [ 09/Mar/22 ] |
|
The other place where shellcheck could be usefully added (once it is working in prepare-commit-msg) is in contrib/scripts/gerrit-checkpatch.py, which is doing the actual work of calling checkpatch.pl on each submitted patch and posting comments on the patches in Gerrit. Like in prepare-commit-msg, it would need to determine which files are shell scripts, and then run shellcheck on the file and limit it to lines which are modified by the patch and call add_comment() for each one, and the script should handle the rest. The gerrit-checkpatch.py script is in Python, so I can't help very much with that, but hopefully it is fairly clear. |
| Comment by Arshad Hussain [ 15/Mar/22 ] |
|
Andreas, will have a go at this one |
| Comment by Gerrit Updater [ 11/Jun/22 ] |
|
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/46705/ |
| Comment by Peter Jones [ 11/Jun/22 ] |
|
Landed for 2.16 |