[LU-15683] sanity-flr.sh test_50c: proper initialize fid in OFD objects fallocate handler Created: 24/Mar/22  Updated: 28/Jul/22  Resolved: 30/May/22

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.16.0

Type: Bug Priority: Major
Reporter: Zhenyu Xu Assignee: Zhenyu Xu
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Duplicate
is duplicated by LU-15333 lfsck reports "XATTR trusted.fid: the... Resolved
Related
is related to LU-15519 fallocate does not increase projid qu... Resolved
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

the filter_fid is not initialized before storing into the XATTR value.

 Comments   
Comment by Andreas Dilger [ 24/Mar/22 ]

Is this issue the same as LU-15519, or is it caused by the landing of "LU-15519 quota: fallocate does not increase projectid usage"?

Comment by Andreas Dilger [ 24/Mar/22 ]

Oh, I see that patch is not landed yet, so maybe it is also the fix?

Comment by Gerrit Updater [ 24/Mar/22 ]

"Bobi Jam <bobijam@hotmail.com>" uploaded a new patch: https://review.whamcloud.com/46919
Subject: LU-15683 ofd: proper initialize filter_fid in ofd fallocate
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 54c8c7a9a83f4175cefebdbdce07a14211fd2e1f

Comment by Arshad Hussain [ 24/Mar/22 ]

>Oh, I see that patch is not landed yet, so maybe it is also the fix?

Andreas, we are also missing passing the OBD_MD_FLPROJID flag from vvp,osc etc... Which is taken care by LU-15519

Comment by Zhenyu Xu [ 24/Mar/22 ]

Oh, I see that patch is not landed yet, so maybe it is also the fix?

I think this is another issue I find during investigating https://testing.whamcloud.com/test_sessions/8e4a262c-d321-4842-b992-b6eb5083407a sanity-flr.sh test_50c failure, the OFD object create its layout XATTR_NAME_FID with random layout version, and that the supposed correctly write request got rejected since the layout version passed from the client does not exceeds the random big layout version number.

Comment by Andreas Dilger [ 24/Mar/22 ]

Maybe I'm missing something, but I don't see sanity-flr test_50b calling fallocate? Is it because "lfs mirror resync" is using PUNCH when resyncing the file with holes?

Comment by Zhenyu Xu [ 11/Apr/22 ]

yes, mirror resync uses fallocate to punch hole in destination mirror. llapi_mirror_resync_many()->llapi_mirror_punch()->llapi_hole_punch()->fallocate() 

Comment by Gerrit Updater [ 30/May/22 ]

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/46919/
Subject: LU-15683 ofd: proper initialize filter_fid in ofd fallocate
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 755fdc6678836652302cea51f838e4894f2a7efc

Comment by Peter Jones [ 30/May/22 ]

Landed for 2.16

Generated at Sat Feb 10 03:20:25 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.