[LU-1574] Unitialized obd_device attached to lu_device Created: 27/Jun/12 Updated: 18/Apr/13 Resolved: 18/Apr/13 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.3.0 |
| Fix Version/s: | Lustre 2.4.0 |
| Type: | Bug | Priority: | Major |
| Reporter: | Johann Lombardi (Inactive) | Assignee: | Mikhail Pershin |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Severity: | 3 |
| Rank (Obsolete): | 4049 |
| Description |
|
From the osd layer, it seems that dt_device::dd_lu_dev::ld_obd points to an uninitialized obd device which isn't the one created from configuration logs. For instance, all error messages in lustre/osd-ldiskfs/osd_handler.c using the prefix ("%s: ...", dev->od_dt_dev.dd_lu_dev.ld_obd->obd_name) now prints "(null): ....". It seems that the lu devices are now configured directly from the mdt (see mdt_stack_init()), but they don't seem to point to any valid obd. I guess the intent is to get rid off obd_device in the end, but this should probably be replaced by some common structure where the device can find its service name (or the osd device should record its service name as on orion). |
| Comments |
| Comment by Alex Zhuravlev [ 27/Jun/12 ] |
|
I'd say we should fix osd and do not refer obd from there, if possible. |
| Comment by Johann Lombardi (Inactive) [ 27/Jun/12 ] |
|
http://review.whamcloud.com/#change,3160 already stores the service name in osd_device. However, it would need a follow-up patch to fix all references to obd_name in osd. |
| Comment by Mikhail Pershin [ 27/Jun/12 ] |
|
I'd said it is not bug but design on new MDS in 2.0, there is only MDT configured from config llog and have initialized OBD device, other layers are set up by MDT and has not fully set OBD. Orion approach is different, it sets all layers from config llog. I agree that better fix for this in master would be just service name usage instead of obd_name |
| Comment by Johann Lombardi (Inactive) [ 27/Jun/12 ] |
|
Maybe we should put the name in the lu_device then? |
| Comment by Jodi Levi (Inactive) [ 05/Jul/12 ] |
|
Can you take a look at this one? |
| Comment by Johann Lombardi (Inactive) [ 06/Sep/12 ] |
|
IMHO, this bug is quite annoying and will for sure trigger user complaints. |
| Comment by Mikhail Pershin [ 06/Sep/12 ] |
|
OK, I'll prepare fix. |
| Comment by Mikhail Pershin [ 08/Oct/12 ] |
|
fix landed |