[LU-15811] simplify lower/upper AIO/DIO code Created: 02/May/22  Updated: 05/Apr/23  Resolved: 01/Sep/22

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.16.0, Lustre 2.15.2

Type: Bug Priority: Major
Reporter: Patrick Farrell Assignee: Patrick Farrell
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Related
is related to LU-16132 NULL pointer dereference lu_object_put Resolved
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

One of the patches for LU-13799, "Implement lower/upper aio" (https://review.whamcloud.com/44209/) created a complicated setup where the cl_dio_aio struct was used both for the top level DIO or AIO and for the lower level sub I/Os (corresponding to stripes).

This is quite complicated and hard to follow, so this rewrites these two uses to be separate structs.  This incidentally fixes at least one possible memory leak.

This is an attempt to clean up the code to make some bugs easier to identify.  This may be a prelude to moving the top level AIO to a different struct from the DIO.

 Comments   
Comment by Gerrit Updater [ 02/May/22 ]

"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/47187
Subject: LU-15811 llite: Rework upper/lower DIO/AIO
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: fb8b38b8f6e91889923b60c543c23c6da9cad9f6

Comment by Gerrit Updater [ 20/Jul/22 ]

"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/48000
Subject: LU-15811 llite: Unify range unlock
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: f197d66fe509b891a17f5ccf7af1f239a3eb296b

Comment by Gerrit Updater [ 03/Aug/22 ]

"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/48115
Subject: LU-15811 llite: Refactor DIO/AIO free code
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 7d83fa1abc4c23308b42eec381f1da450ff7c8ce

Comment by Gerrit Updater [ 01/Sep/22 ]

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/47187/
Subject: LU-15811 llite: Rework upper/lower DIO/AIO
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 51c18539338f1a23f3fa725470b5d36941b15c46

Comment by Gerrit Updater [ 01/Sep/22 ]

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/48000/
Subject: LU-15811 llite: Unify range unlock
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 36c34af60767bd5da5e9a66df0297e1dc7fa1fb1

Comment by Gerrit Updater [ 01/Sep/22 ]

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/48115/
Subject: LU-15811 llite: Refactor DIO/AIO free code
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f1c8ac1156ebea2b8e94a75f056c403973bb9010

Comment by Peter Jones [ 01/Sep/22 ]

Landed for 2.16

Comment by Gerrit Updater [ 17/Sep/22 ]

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/48454/
Subject: LU-15811 llite: Rework upper/lower DIO/AIO
Project: fs/lustre-release
Branch: b2_15
Current Patch Set:
Commit: 1aca3426cde3ca3457bb3fa44c70ac91922df13d

Comment by Gerrit Updater [ 17/Sep/22 ]

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/48455/
Subject: LU-15811 llite: Unify range unlock
Project: fs/lustre-release
Branch: b2_15
Current Patch Set:
Commit: 505c13b066547f41c80c90227be20259c0d22f35

Comment by Gerrit Updater [ 17/Sep/22 ]

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/48456/
Subject: LU-15811 llite: Refactor DIO/AIO free code
Project: fs/lustre-release
Branch: b2_15
Current Patch Set:
Commit: 076938e18315d05ae8da49270a7c43876fccfadf

Generated at Sat Feb 10 03:21:30 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.