[LU-15894] Range locking in ofd is no longer needed Created: 26/May/22  Updated: 17/Jan/23  Resolved: 12/Jul/22

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.16.0

Type: Task Priority: Minor
Reporter: Andrew Perepechko Assignee: Andrew Perepechko
Resolution: Fixed Votes: 0
Labels: patch

Rank (Obsolete): 9223372036854775807

 Description   

Range locking in ofd is no longer needed. It can unnecessarily serialize I/O under certain load.

A patch will be uploaded shortly.



 Comments   
Comment by Gerrit Updater [ 26/May/22 ]

"Andrew Perepechko <andrew.perepechko@hpe.com>" uploaded a new patch: https://review.whamcloud.com/47466
Subject: LU-15894 ofd: revert range locking in ofd
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: cc86d0f60bb46c33be84e8dc7b0083b365f99161

Comment by Gerrit Updater [ 11/Jul/22 ]

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/47466/
Subject: LU-15894 ofd: revert range locking in ofd
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: a21ce928aa641cbfacb9dde74e4be1cd1b658fb0

Comment by Peter Jones [ 12/Jul/22 ]

Landed for 2.16

Comment by Lukasz Flis [ 12/Dec/22 ]

Do you plan to merge this one to b2_15 as well as 301d76a711 is already there?

Comment by Lukasz Flis [ 17/Jan/23 ]

More info

We are using 2_15 with
LU-15894 ofd: revert range locking in ofd
LU-16286 ldiskfs: reimplement nodelalloc optimization 
on our NVME servers what increased fio 4k-rand-write test from 4k iops to 68-100k

before
randwrite-4k: (groupid=0, jobs=32): err= 0: pid=887088: Wed Dec 14 15:06:43 2022
  write: IOPS=4823, BW=18.8MiB/s (19.8MB/s)(4678MiB/248288msec); 0 zone resets
   bw (  KiB/s): min= 3056, max=392881, per=100.00%, avg=61835.30, stdev=1467.54, samples=4847

after  patching
randwrite-4k: (groupid=0, jobs=32): err= 0: pid=530015: Mon Jan 16 14:26:16 2023
  write: IOPS=68.6k, BW=268MiB/s (281MB/s)(62.9GiB/240336msec); 0 zone resets

Generated at Sat Feb 10 03:22:12 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.